Update dependency eslint-plugin-unicorn to v41 (#339)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Caleb Eby <caleb.eby01@gmail.com>

Author: 3 people

.changeset/popular-laws-live.md

@@ -0,0 +1,32 @@
+---
+'@cloudfour/eslint-plugin': major
+---
+
+Update `eslint-plugin-unicorn` to `v41`
+
+**New Rules**
+
+- [`@cloudfour/unicorn/no-await-expression-member`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-await-expression-member.md)
+- [`@cloudfour/unicorn/no-empty-file`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-empty-file.md)
+- [`@cloudfour/unicorn/no-thenable`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-thenable.md)
+- [`@cloudfour/unicorn/no-useless-promise-resolve-reject`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-useless-promise-resolve-reject.md)
+- [`@cloudfour/unicorn/prefer-code-point`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/prefer-code-point.md)
+- [`@cloudfour/unicorn/prefer-export-from`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/prefer-export-from.md)
+- [`@cloudfour/unicorn/prefer-json-parse-buffer`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/prefer-json-parse-buffer.md)
+- [`@cloudfour/unicorn/relative-url-style`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/relative-url-style.md)
+- [`@cloudfour/unicorn/text-encoding-identifier-case`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/text-encoding-identifier-case.md)
+
+**Newly Enabled Rules**
+
+- [`@cloudfour/unicorn/no-await-expression-member`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-await-expression-member.md)
+- [`@cloudfour/unicorn/no-empty-file`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-empty-file.md)
+- [`@cloudfour/unicorn/no-thenable`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-thenable.md)
+- [`@cloudfour/unicorn/no-useless-promise-resolve-reject`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/no-useless-promise-resolve-reject.md)
+- [`@cloudfour/unicorn/prefer-code-point`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/prefer-code-point.md)
+- [`@cloudfour/unicorn/prefer-export-from`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/prefer-export-from.md)
+- [`@cloudfour/unicorn/relative-url-style`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/relative-url-style.md)
+- [`@cloudfour/unicorn/text-encoding-identifier-case`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/text-encoding-identifier-case.md)
+
+**Newly Disabled Rules**
+
+- [`@cloudfour/unicorn/require-post-message-target-origin`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v41.0.1/docs/rules/require-post-message-target-origin.md)

fixtures/eslint/lib/linter/linter.js

@@ -654,7 +654,7 @@ function stripUnicodeBOM(text) {
    * In JavaScript, string data is stored as UTF-16, so BOM is 0xFEFF.
    * http://www.ecma-international.org/ecma-262/6.0/#sec-unicode-format-control-characters
    */
-  if (text.charCodeAt(0) === 0xfe_ff) {
+  if (text.codePointAt(0) === 0xfe_ff) {
     return text.slice(1);
   }
 

fixtures/eslint/lib/source-code/source-code.js

@@ -186,7 +186,7 @@ class SourceCode extends TokenStore {
      * The flag to indicate that the source code has Unicode BOM.
      * @type boolean
      */
-    this.hasBOM = text.charCodeAt(0) === 0xfe_ff;
+    this.hasBOM = text.codePointAt(0) === 0xfe_ff;
 
     /**
      * The original text source code.

fixtures/rollup/rollup.config.js

@@ -16,7 +16,7 @@ import pkg from './package.json';
 
 const commitHash = (function () {
   try {
-    return fs.readFileSync('.commithash', 'utf-8');
+    return fs.readFileSync('.commithash', 'utf8');
   } catch {
     return 'unknown';
   }
@@ -142,11 +142,11 @@ export default (command) => {
       {
         load: (id) => {
           if (id.includes('crypto.ts'))
-            return fs.readFileSync('browser/crypto.ts', 'utf-8');
+            return fs.readFileSync('browser/crypto.ts', 'utf8');
           if (id.includes('fs.ts'))
-            return fs.readFileSync('browser/fs.ts', 'utf-8');
+            return fs.readFileSync('browser/fs.ts', 'utf8');
           if (id.includes('path.ts'))
-            return fs.readFileSync('browser/path.ts', 'utf-8');
+            return fs.readFileSync('browser/path.ts', 'utf8');
         },
       },
       commonjs(),

package-lock.json

@@ -37,7 +37,7 @@
     "eslint-plugin-jsdoc": "^38.0.0",
     "eslint-plugin-n": "^15.0.1",
     "eslint-plugin-promise": "^6.0.0",
-    "eslint-plugin-unicorn": "^37.0.0"
+    "eslint-plugin-unicorn": "^41.0.0"
   },
   "peerDependencies": {
     "eslint": "^8.0.0"

package.json

@@ -156,6 +156,9 @@ module.exports.configs = {
         // But this is an edge case that can be avoided through careful manual review
         // and sometimes through TS
         'unicorn/no-array-callback-reference': 'off',
+        // https://github.com/sindresorhus/eslint-plugin-unicorn/pull/1750
+        // This rule got removed from the recommended preset, but that hasn't been published yet.
+        'unicorn/prefer-json-parse-buffer': 'off',
         // This rule changes arrays to sets if you call .includes on it
         // Converting from array to set has a cost itself, just like .includes has a cost
         // We decided to leave the decision of using arrays vs sets to human reviewers