Skip to content

Commit 33ddf04

Browse files
authored
Ignore HTML comments in getAccessibilityTree output (#412)
1 parent 9c130fb commit 33ddf04

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

.changeset/heavy-wombats-vanish.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'pleasantest': patch
3+
---
4+
5+
Ignore HTML comments in `getAccessibilityTree` output (potentially breaking bugfix)

src/accessibility/browser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export const getAccessibilityTree = (
122122
let printedChild;
123123
if (node instanceof Element) {
124124
printedChild = getAccessibilityTree(node, opts, requiredOwnedElements);
125-
} else if (includeText) {
125+
} else if (includeText && !(node instanceof Comment)) {
126126
const trimmedText = node.nodeValue?.trim();
127127
if (!trimmedText) continue;
128128

tests/accessibility/getAccessibilityTree.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ test(
3434
<span aria-hidden="true">+</span>
3535
<span>Add to cart</span>
3636
</button>
37+
<!-- This comment shouldn't show up -->
3738
<h1>hiiii</h1>
3839
<div role="button" tabindex="-1">foo &gt bar</div>
3940
</main>

0 commit comments

Comments
 (0)