Fix erasing items in loop

Fixes a loop where WorldObjects were removed from a vector while iterating in it, leading to undesired behaviour.

Author: ssj17vegeta

src/game/DBScripts/ScriptMgr.cpp

@@ -1521,9 +1521,10 @@ std::pair<bool, bool> ScriptAction::GetScriptProcessTargets(WorldObject* origina
                     buddies.push_back(closest);
             }
             if (m_script->searchRadiusOrGuid > 0)
-                for (WorldObject* buddy : buddies)
-                    if (!buddy->IsWithinDist(origin, m_script->searchRadiusOrGuid))
-                        buddies.erase(std::remove(buddies.begin(), buddies.end(), buddy), buddies.end());
+                buddies.erase(std::remove_if(buddies.begin(), buddies.end(), [&](WorldObject* buddy)
+                {
+                    return !buddy->IsWithinDist(origin, m_script->searchRadiusOrGuid);
+                }), buddies.end());
 
             if (buddies.empty() && m_script->command != SCRIPT_COMMAND_TERMINATE_SCRIPT)
             {