GameObject: Add rest of CanUseNow for GO checks

Co-Authored-By: robinsch <robinsch@users.noreply.github.com>

Author: killerwife

src/game/Entities/GameObject.cpp

@@ -1512,6 +1512,40 @@ bool GameObject::CanUseNow(Player const* player) const
         }
     }
 
+    if (!GetGOInfo()->GetLockId())
+    {
+        // ignore for remote control state
+        if (!player->IsSelfMover())
+        {
+            // check player on vehicle
+            if (!player->GetTransportInfo() || !player->GetTransportInfo()->IsOnVehicle() || !GetGOInfo()->IsUsableMounted())
+                return false;
+        }
+
+        // We can't interact with anyone while being shapeshifted, unless form flags allow us to do so
+        if (player->IsShapeShifted())
+        {
+            if (SpellShapeshiftFormEntry const* formEntry = sSpellShapeshiftFormStore.LookupEntry(player->GetShapeshiftForm()))
+            {
+                if (!(formEntry->flags1 & SHAPESHIFT_FLAG_CAN_NPC_INTERACT) && player->HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_TAXI_FLIGHT)) // meant to have an can unshift check here
+                    return false;
+            }
+            else
+                return false;
+        }
+    }
+
+    // client checks this but needs recheck
+    if (GetGOInfo()->IsUsableInCombat() && player->IsInCombat())
+        return false;
+
+    // client checks this but needs recheck
+    if (GetGOInfo()->CannotBeUsedUnderImmunity() && player->HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE))
+        return false;
+
+    if (HasFlag(GAMEOBJECT_FLAGS, GO_FLAG_LOCKED) && !GetSpellForLock(player)) // we should not allow use of a locked GO
+        return false;
+
     return true;
 }
 
@@ -2947,10 +2981,17 @@ SpellEntry const* GameObject::GetSpellForLock(Player const* player) const
 
         for (auto&& playerSpell : player->GetSpellMap())
             if (SpellEntry const* spellInfo = sSpellTemplate.LookupEntry<SpellEntry>(playerSpell.first))
-                for (uint32 i = 0; i < MAX_EFFECT_INDEX; ++i)
-                    if (spellInfo->Effect[i] == SPELL_EFFECT_OPEN_LOCK && ((uint32)spellInfo->EffectMiscValue[i]) == lock->Index[i])
-                        if (player->CalculateSpellEffectValue(nullptr, spellInfo, SpellEffectIndex(i), nullptr) >= int32(lock->Skill[i]))
+                for (uint32 effIdx = 0; effIdx < MAX_EFFECT_INDEX; ++effIdx)
+                    if (spellInfo->Effect[effIdx] == SPELL_EFFECT_OPEN_LOCK && ((uint32)spellInfo->EffectMiscValue[effIdx]) == lock->Index[i])
+                    {
+                        uint32 minRequiredSkill;
+                        if (lock->Skill[i])
+                            minRequiredSkill = lock->Skill[i];
+                        else
+                            minRequiredSkill = GetLevel() * 5;
+                        if (player->CalculateSpellEffectValue(nullptr, spellInfo, SpellEffectIndex(effIdx), nullptr) >= int32(minRequiredSkill))
                             return spellInfo;
+                    }
     }
 
     return nullptr;

src/game/Entities/GameObject.h

@@ -587,6 +587,15 @@ struct GameObjectInfo
         }
     }
 
+    bool IsUsableInCombat() const
+    {
+        switch (type)
+        {
+            case GAMEOBJECT_TYPE_CHEST: return chest.notInCombat == 0;
+            default: return true;
+        }
+    }
+
     bool IsInfiniteGameObject() const
     {
         switch (type)

src/game/Spells/SpellHandler.cpp

@@ -321,24 +321,13 @@ void WorldSession::HandleGameObjectUseOpcode(WorldPacket& recv_data)
         return;
     }
 
-    // ignore for remote control state
-    if (!_player->IsSelfMover())
-    {
-        // check player on vehicle
-        if (!_player->GetTransportInfo() || !_player->GetTransportInfo()->IsOnVehicle() || !obj->GetGOInfo()->IsUsableMounted())
-            return;
-    }
-
     // Never expect this opcode for some type GO's
     if (obj->GetGoType() == GAMEOBJECT_TYPE_GENERIC)
     {
         sLog.outError("HandleGameObjectUseOpcode: CMSG_GAMEOBJ_USE for not allowed GameObject type %u (Entry %u), didn't expect this to happen.", obj->GetGoType(), obj->GetEntry());
         return;
     }
 
-    if (obj->HasFlag(GAMEOBJECT_FLAGS, GO_FLAG_LOCKED)) // we should not allow use of a locked GO
-        return;
-
     if (obj->HasFlag(GAMEOBJECT_FLAGS, GO_FLAG_IN_USE))
         return;
 
@@ -349,10 +338,6 @@ void WorldSession::HandleGameObjectUseOpcode(WorldPacket& recv_data)
         return;
     }
 
-    // client checks this but needs recheck
-    if (obj->GetGOInfo()->CannotBeUsedUnderImmunity() && _player->HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE))
-        return;
-
     if (!obj->CanUseNow(_player))
         return;