Bank: Fix guild bank access in wotlk.

Author: mostlikely4r

playerbot/strategy/actions/GuildBankAction.cpp

@@ -6,6 +6,7 @@
 #include "playerbot/strategy/values/ItemUsageValue.h"
 #include "Guilds/Guild.h"
 #include "Guilds/GuildMgr.h"
+#include "playerbot/strategy/values/GuildValues.h"
 
 using namespace ai;
 
@@ -166,7 +167,12 @@ bool GuildBankAction::AutoWithdraw(GameObject* bank)
 
         for (uint8 slotId = 0; slotId < GUILD_BANK_MAX_SLOTS; ++slotId)
         {
+#ifdef MANGOSBOT_TWO
+            GuildAccess* guildAccess = reinterpret_cast<GuildAccess*>(guild);
+            Item* item = guildAccess->GetItem(tabId, slotId);
+#else
             Item* item = guild->GetItem(tabId, slotId);
+#endif
             if (!item)
                 continue;
 

playerbot/strategy/values/BankValues.cpp

@@ -4,6 +4,7 @@
 #include "ItemCountValue.h"
 #include "Guilds/Guild.h"
 #include "Guilds/GuildMgr.h"
+#include "playerbot/strategy/values/GuildValues.h"
 
 using namespace ai;
 
@@ -196,7 +197,12 @@ bool ShouldGuildBankWithdrawValue::Calculate()
 
         for (uint8 slotId = 0; slotId < GUILD_BANK_MAX_SLOTS; ++slotId)
         {
+#ifdef MANGOSBOT_TWO
+            GuildAccess* guildAccess = reinterpret_cast<GuildAccess*>(guild);
+            Item* item = guildAccess->GetItem(tabId, slotId);
+#else
             Item* item = guild->GetItem(tabId, slotId);
+#endif
             if (!item)
                 continue;
 

playerbot/strategy/values/GuildValues.cpp

@@ -10,6 +10,15 @@
 
 using namespace ai;
 
+#ifdef MANGOSBOT_TWO
+Item* GuildAccess::GetItem(uint8 TabId, uint8 SlotId)
+{
+    if (TabId >= GetPurchasedTabs() || SlotId >= GUILD_BANK_MAX_SLOTS)
+        return nullptr;
+    return m_TabList[TabId].Slots[SlotId];
+}
+#endif
+
 std::string GuildOrderValue::TrimWhitespace(const std::string& str)
 {
     std::string result = str;

playerbot/strategy/values/GuildValues.h

@@ -1,8 +1,56 @@
 #pragma once
 #include "playerbot/strategy/Value.h"
+#include "Guilds/Guild.h"
 
 namespace ai
 {
+#ifdef MANGOSBOT_TWO
+    // Accessor class to reach private Guild methods (mirrors LootAccess pattern)
+    class GuildAccess
+    {
+    public:
+        uint8 GetPurchasedTabs() const { return m_TabList.size(); }
+        Item* GetItem(uint8 TabId, uint8 SlotId);
+    private:
+        typedef std::unordered_map<uint32, MemberSlot> MemberList;
+        typedef std::vector<RankInfo> RankList;
+        uint32 m_Id;
+        std::string m_Name;
+        ObjectGuid m_LeaderGuid;
+        std::string MOTD;
+        std::string GINFO;
+        time_t m_CreatedDate;
+
+        uint32 m_EmblemStyle;
+        uint32 m_EmblemColor;
+        uint32 m_BorderStyle;
+        uint32 m_BorderColor;
+        uint32 m_BackgroundColor;
+        uint32 m_accountsNumber; // 0 used as marker for need lazy calculation at request
+
+        RankList m_Ranks;
+
+        MemberList members;
+
+        std::vector<GuildBankTab> m_TabList;
+
+        /** These are actually ordered lists. The first element is the oldest entry.*/
+        typedef std::list<GuildEventLogEntry> GuildEventLog;
+        typedef std::list<GuildBankEventLogEntry> GuildBankEventLog;
+        GuildEventLog m_GuildEventLog;
+        GuildBankEventLog m_GuildBankEventLog_Money;
+        GuildBankEventLog m_GuildBankEventLog_Item[GUILD_BANK_MAX_TABS];
+
+        uint32 m_GuildEventLogNextGuid;
+        uint32 m_GuildBankEventLogNextGuid_Money;
+        uint32 m_GuildBankEventLogNextGuid_Item[GUILD_BANK_MAX_TABS];
+
+        uint64 m_GuildBankMoney;
+
+        MaNGOS::unique_weak_ptr<Guild> m_weakRef;
+    };
+#endif
+
     enum class GuildOrderType : uint8
     {
         None = 0,
@@ -126,7 +174,7 @@ namespace ai
             }
 
             QuestStatus status = bot->GetQuestStatus(order.questId);
-            // Quest already in log (incomplete or complete) — no need to accept.
+            // Quest already in log (incomplete or complete) no need to accept.
             if (status == QUEST_STATUS_INCOMPLETE || status == QUEST_STATUS_COMPLETE)
                 return false;