fix: handle windows drive letter at start of path#1099
Merged
joseph-sentry merged 1 commit intomainfrom Aug 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
+ Coverage 92.47% 92.53% +0.06%
==========================================
Files 36 36
Lines 1342 1353 +11
Branches 272 272
==========================================
+ Hits 1241 1252 +11
Misses 69 69
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/check-windows
branch
from
8c1932b to
4a199de
Compare
joseph-sentry
changed the title
Contributor
|
@joseph-sentry could you write a test for this? |
joseph-sentry
force-pushed
the
joseph/check-windows
branch
2 times, most recently
from
f04f5f2 to
685da7a
Compare
thomasrockhu-codecov
approved these changes
Aug 8, 2023
src/helpers/files.ts
Outdated
| filePath.startsWith('.\\') || | ||
| filePath.startsWith('.\\') | ||
| filePath.startsWith('.\\') || | ||
| /^[A-Z]:\\\S*/.test(filePath) |
Contributor
There was a problem hiding this comment.
for sanity, just add a comment here why we are doing this
joseph-sentry
force-pushed
the
joseph/check-windows
branch
from
685da7a to
cd45cd5
Compare
Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/check-windows
branch
from
cd45cd5 to
0e48a36
Compare
thomasrockhu-codecov
pushed a commit
that referenced
this pull request
Oct 10, 2023
Signed-off-by: joseph-sentry <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #544