Skip to content

fix: update windows node version#1134

Merged
thomasrockhu-codecov merged 8 commits intomainfrom
fix-windows
Aug 23, 2023
Merged

fix: update windows node version#1134
thomasrockhu-codecov merged 8 commits intomainfrom
fix-windows

Conversation

@thomasrockhu-codecov
Copy link
Copy Markdown
Contributor

No description provided.

@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner August 23, 2023 03:27
@thomasrockhu-codecov thomasrockhu-codecov changed the title [Do not merge] fix: add nvm list and use specific version [Do not merge] fix: update windows node version Aug 23, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1134 (e15846b) into main (d761d30) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   92.55%   92.48%   -0.08%     
==========================================
  Files          36       36              
  Lines        1357     1357              
  Branches      273      273              
==========================================
- Hits         1256     1255       -1     
- Misses         69       70       +1     
  Partials       32       32              
Flag Coverage Δ
aarch64 92.48% <ø> (ø)
aarch64-without-git 92.48% <ø> (ø)
alpine 92.48% <ø> (ø)
alpine-proxy 92.48% <ø> (ø)
alpine-without-git 92.48% <ø> (ø)
linux 92.48% <ø> (ø)
linux-without-git 92.48% <ø> (ø)
macos 92.48% <ø> (ø)
macos-without-git 92.48% <ø> (ø)
windows 92.48% <ø> (+1.40%) ⬆️
windows-without-git 92.48% <ø> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@thomasrockhu-codecov thomasrockhu-codecov changed the title [Do not merge] fix: update windows node version fix: update windows node version Aug 23, 2023
@thomasrockhu-codecov thomasrockhu-codecov merged commit dfeedf5 into main Aug 23, 2023
@thomasrockhu-codecov thomasrockhu-codecov deleted the fix-windows branch August 23, 2023 17:28
thomasrockhu-codecov added a commit that referenced this pull request Oct 10, 2023
* fix: add nvm list and use specific version

* fix: bump to node17 for windows

* fix: just use 17

* fix: specify exact node version

* fix: bump back down to v16

* fix: logs

* fix: all the dir

* fix: remove C things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants