Skip to content

fix: paths work correctly on windows#143

Merged
drazisil-codecov merged 1 commit intoreleasefrom
master
Jun 15, 2021
Merged

fix: paths work correctly on windows#143
drazisil-codecov merged 1 commit intoreleasefrom
master

Conversation

@drazisil-codecov
Copy link
Copy Markdown
Contributor

No description provided.

@drazisil-codecov drazisil-codecov requested a review from a team as a code owner June 15, 2021 18:35
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 15, 2021

Codecov Report

Merging #143 (5856d15) into release (b71ea21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release     #143   +/-   ##
========================================
  Coverage    91.57%   91.57%           
========================================
  Files           15       15           
  Lines          546      546           
  Branches       105      105           
========================================
  Hits           500      500           
  Misses          20       20           
  Partials        26       26           
Flag Coverage Δ
alpine 91.57% <ø> (ø)
linux 91.57% <ø> (ø)
linux-without-git ∅ <ø> (∅)
macos 91.57% <ø> (ø)
macos-without-git ∅ <ø> (∅)
windows 91.02% <ø> (ø)
windows-without-git ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71ea21...5856d15. Read the comment docs.

@drazisil-codecov drazisil-codecov merged commit 8bbff35 into release Jun 15, 2021
@RA80533
Copy link
Copy Markdown
Contributor

RA80533 commented Jun 16, 2021

Where is the fix? It appears this PR only changes the README.md.

@drazisil-codecov
Copy link
Copy Markdown
Contributor Author

Where is the fix? It appears this PR only changes the README.md.

The fix is here 186f731
Due to some bad timing , it triggered a release that didn't mention the fix. This is a README change so I had a release that mentioned the fix.

The confusing release was https://github.com/codecov/uploader/releases/tag/v0.1.0_4399

@RA80533
Copy link
Copy Markdown
Contributor

RA80533 commented Jun 21, 2021

It looks like 186f731 contains a fix related to POSIX paths instead of Windows.

Was there a previous issue with paths not working correctly in one of the two OS environments?

@drazisil-codecov
Copy link
Copy Markdown
Contributor Author

It looks like 186f731 contains a fix related to POSIX paths instead of Windows.

Was there a previous issue with paths not working correctly in one of the two OS environments?

Yes, on Windows the files were being listed at their pull path, including the drive letter, which caused them to not match the files in coverage reports. By telling path to always use posix form, the file paths are now the same cross-platform. Prior to this fix, uploads on Windows would upload, but fail to process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants