Fix: @returns JSDoc annotations for string#162
Fix: @returns JSDoc annotations for string#162drazisil-codecov merged 2 commits intocodecov:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 92.17% 91.99% -0.19%
==========================================
Files 15 15
Lines 537 537
Branches 101 101
==========================================
- Hits 495 494 -1
Misses 16 16
- Partials 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
drazisil-codecov
left a comment
There was a problem hiding this comment.
I notice in some places there is String and in others there is string. I think these have different meanings and they all should be string https://jsdoc.app/tags-type.html
Do you mind changing them over? If not, I'll just open another issue and merge this one :)
|
I will make the changes in a couple of minutes. |
|
Drop in coverage reported is incorrect. I believe it's due to whitespace somehow, will check the raw reports. Disregard. |
|
I think it is mergeable now. @drazisil-codecov. Also Thanks @drazisil-codecov , @RA80533 for the quick review. |
Affected files appears exactly the same. @thomasrockhu do you have any thoughts here? |
drazisil-codecov
left a comment
There was a problem hiding this comment.
Awesome! Thank you very much for the PR, @Patil2099 ! 🚀
Fixes #153