Skip to content

Fix: @returns JSDoc annotations for string#162

Merged
drazisil-codecov merged 2 commits intocodecov:masterfrom
Patil2099:master
Jun 23, 2021
Merged

Fix: @returns JSDoc annotations for string#162
drazisil-codecov merged 2 commits intocodecov:masterfrom
Patil2099:master

Conversation

@Patil2099
Copy link
Copy Markdown
Contributor

Fixes #153

@Patil2099 Patil2099 requested a review from a team as a code owner June 23, 2021 15:23
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2021

Codecov Report

Merging #162 (61456da) into master (8b47a96) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   92.17%   91.99%   -0.19%     
==========================================
  Files          15       15              
  Lines         537      537              
  Branches      101      101              
==========================================
- Hits          495      494       -1     
  Misses         16       16              
- Partials       26       27       +1     
Flag Coverage Δ
alpine 91.99% <ø> (-0.19%) ⬇️
linux 91.99% <ø> (-0.19%) ⬇️
linux-without-git ∅ <ø> (∅)
macos 91.99% <ø> (-0.19%) ⬇️
macos-without-git ∅ <ø> (∅)
windows 91.43% <ø> (-0.19%) ⬇️
windows-without-git ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ci_providers/provider_azurepipelines.js 94.00% <ø> (ø)
src/helpers/files.js 92.85% <ø> (ø)
src/helpers/web.js 85.29% <ø> (ø)
src/index.js 75.30% <ø> (ø)
src/ci_providers/provider_circleci.js 90.32% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b47a96...61456da. Read the comment docs.

Copy link
Copy Markdown
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice in some places there is String and in others there is string. I think these have different meanings and they all should be string https://jsdoc.app/tags-type.html

Do you mind changing them over? If not, I'll just open another issue and merge this one :)

@Patil2099
Copy link
Copy Markdown
Contributor Author

I will make the changes in a couple of minutes.

@drazisil-codecov
Copy link
Copy Markdown
Contributor

Drop in coverage reported is incorrect. I believe it's due to whitespace somehow, will check the raw reports. Disregard.

@Patil2099
Copy link
Copy Markdown
Contributor Author

Patil2099 commented Jun 23, 2021

I think it is mergeable now. @drazisil-codecov. Also Thanks @drazisil-codecov , @RA80533 for the quick review.

@drazisil-codecov
Copy link
Copy Markdown
Contributor

Drop in coverage reported is incorrect. I believe it's due to whitespace somehow, will check the raw reports. Disregard.

BASE: https://codecov.io/gh/codecov/uploader/src/8b47a96b265501d5dd9d185c140e439b8034435c/src/ci_providers/provider_azurepipelines.js

HEAD: https://codecov.io/gh/codecov/uploader/src/f95dc670855ef62d83aded4cd6951ca18f10cf1e/src/ci_providers/provider_azurepipelines.js

Affected files appears exactly the same. @thomasrockhu do you have any thoughts here?

Copy link
Copy Markdown
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you very much for the PR, @Patil2099 ! 🚀

@drazisil-codecov drazisil-codecov merged commit 8230f56 into codecov:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@returns JSDoc annotations are incorrect

3 participants