Skip to content

fix: parse both versions of ssh urls for remotes#793

Merged
drazisil-codecov merged 3 commits intocodecov:mainfrom
vihangm:ssh_url
Jun 10, 2022
Merged

fix: parse both versions of ssh urls for remotes#793
drazisil-codecov merged 3 commits intocodecov:mainfrom
vihangm:ssh_url

Conversation

@vihangm
Copy link
Copy Markdown
Contributor

@vihangm vihangm commented Jun 3, 2022

Fixes #792
Signed-off-by: Vihang Mehta [email protected]

@vihangm vihangm requested a review from a team as a code owner June 3, 2022 15:49
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2022

Codecov Report

Merging #793 (66188c7) into main (9e51b9c) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   92.33%   92.42%   +0.08%     
==========================================
  Files          33       33              
  Lines        1161     1161              
  Branches      234      235       +1     
==========================================
+ Hits         1072     1073       +1     
  Misses         57       57              
+ Partials       32       31       -1     
Flag Coverage Δ
alpine 92.42% <100.00%> (+0.08%) ⬆️
alpine-proxy 92.42% <100.00%> (+0.08%) ⬆️
alpine-without-git 92.42% <100.00%> (+0.08%) ⬆️
linux 92.42% <100.00%> (+0.08%) ⬆️
linux-without-git 92.42% <100.00%> (+0.08%) ⬆️
macos 92.42% <100.00%> (+0.08%) ⬆️
macos-without-git 92.42% <100.00%> (+0.08%) ⬆️
windows 92.42% <100.00%> (+0.08%) ⬆️
windows-without-git 92.42% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/git.ts 81.81% <100.00%> (+4.54%) ⬆️

@drazisil-codecov
Copy link
Copy Markdown
Contributor

@vihangm Thank you for the PR. My apologies that I didn't see it until after I released the latest version.

I'll try to get another one out soon for you with these changes.

@drazisil-codecov drazisil-codecov merged commit 84df6d1 into codecov:main Jun 10, 2022
This was referenced Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slug Parser doesn't parse ssh:// urls

2 participants