feat: create fixes on c-like and php files#869
Merged
thomasrockhu-codecov merged 2 commits intomainfrom Sep 1, 2022
Merged
Conversation
thomasrockhu-codecov
force-pushed
the
feat-fixes
branch
from
1288573 to
aeedfa1
Compare
Codecov Report
@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 91.87% 92.13% +0.26%
==========================================
Files 34 35 +1
Lines 1181 1221 +40
Branches 244 249 +5
==========================================
+ Hits 1085 1125 +40
Misses 64 64
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mitchell-codecov
approved these changes
Sep 1, 2022
Comment on lines
+24
to
+47
| for (const file of allFiles) { | ||
| let lineAdjustments: string[] = [] | ||
|
|
||
| if ( | ||
| file.match(/\.c$/) || | ||
| file.match(/\.cpp$/) || | ||
| file.match(/\.h$/) || | ||
| file.match(/\.hpp$/) || | ||
| file.match(/\.m$/) || | ||
| file.match(/\.swift$/) || | ||
| file.match(/\.vala$/) | ||
| ) { | ||
| lineAdjustments = await getMatchedLines(file, [EMPTYLINE, SYNTAXBRACKET]) | ||
| } else if ( | ||
| file.match(/\.php$/) | ||
| ) { | ||
| lineAdjustments = await getMatchedLines(file, [SYNTAXBRACKET, SYNTAXLIST]) | ||
| } | ||
|
|
||
| if (lineAdjustments.length > 0) { | ||
| UploadLogger.verbose(`Matched file ${file} for adjustments: ${lineAdjustments.join(',')}`) | ||
| allAdjustments.push(`${file}:${lineAdjustments.join(',')}\n`) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
A future PR should move these promises into Promise.all or Promise.allSettled.
mitchell-codecov
pushed a commit
that referenced
this pull request
Sep 1, 2022
* feat: create fixes on c-like and php files * fix: add e2e test for fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.