Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

[match-highlighter] Added wordsOnly option#2791

Closed
danieleds wants to merge 3 commits intocodemirror:masterfrom
danieleds:match-highlight-word
Closed

[match-highlighter] Added wordsOnly option#2791
danieleds wants to merge 3 commits intocodemirror:masterfrom
danieleds:match-highlight-word

Conversation

@danieleds
Copy link
Copy Markdown
Contributor

Adds the option to highlight the selection only if it's a word.
The "delay" option was missing from the documentation, I added it.

@danieleds danieleds changed the title Added wordsOnly option. Updated documentation. [match-highlighter] Added wordsOnly option Sep 1, 2014
Comment thread addon/search/match-highlighter.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have this.delay where it should be this.wordsOnly.

@danieleds
Copy link
Copy Markdown
Contributor Author

Sorry, is this ready to be merged?

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Sep 17, 2014

Yes, it is. Merged as f09b6c5

Note that I do not get an email notification when you push to a pull request branch, and thus am unlikely to notice. It is a good idea to add a comment when you want me to look at the code again.

@marijnh marijnh closed this Sep 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants