fix: allow to sell jokers when a Buffoon pack is open

Closes #156.

Author: S1M0N38

docs/api.md

@@ -395,7 +395,7 @@ curl -X POST http://127.0.0.1:12346 \
 
 ### `sell`
 
-Sell a joker or consumable.
+Sell a joker or consumable. Available in SHOP, SELECTING_HAND states, and when a Buffoon pack is open (to make room for new jokers).
 
 **Parameters:** (exactly one required)
 
@@ -406,7 +406,7 @@ Sell a joker or consumable.
 
 **Returns:** [GameState](#gamestate-schema)
 
-**Errors:** `BAD_REQUEST`, `NOT_ALLOWED`
+**Errors:** `BAD_REQUEST`, `INVALID_STATE`, `NOT_ALLOWED`
 
 **Example:**
 

src/lua/endpoints/sell.lua

@@ -32,7 +32,7 @@ return {
     },
   },
 
-  requires_state = { G.STATES.SELECTING_HAND, G.STATES.SHOP },
+  requires_state = { G.STATES.SELECTING_HAND, G.STATES.SHOP, G.STATES.SMODS_BOOSTER_OPENED },
 
   ---@param args Request.Endpoint.Sell.Params
   ---@param send_response fun(response: Response.Endpoint)
@@ -55,6 +55,22 @@ return {
       return
     end
 
+    -- If in SMODS_BOOSTER_OPENED, verify it's a Buffoon pack (contains Jokers)
+    if G.STATE == G.STATES.SMODS_BOOSTER_OPENED then
+      local pack_set = G.pack_cards
+        and G.pack_cards.cards
+        and G.pack_cards.cards[1]
+        and G.pack_cards.cards[1].ability
+        and G.pack_cards.cards[1].ability.set
+      if pack_set ~= "Joker" then
+        send_response({
+          message = "Can only sell jokers when a Buffoon pack is open",
+          name = BB_ERROR_NAMES.NOT_ALLOWED,
+        })
+        return
+      end
+    end
+
     -- Determine which type to sell and validate existence
     local source_array, pos, sell_type
 
@@ -144,7 +160,11 @@ return {
         local state_stable = G.STATE_COMPLETE == true
 
         -- 5. Still in valid state
-        local valid_state = (G.STATE == G.STATES.SHOP or G.STATE == G.STATES.SELECTING_HAND)
+        local valid_state = (
+          G.STATE == G.STATES.SHOP
+          or G.STATE == G.STATES.SELECTING_HAND
+          or G.STATE == G.STATES.SMODS_BOOSTER_OPENED
+        )
 
         -- All conditions must be met
         if count_decreased and money_increased and card_gone and state_stable and valid_state then

src/lua/utils/openrpc.json

@@ -577,7 +577,7 @@
     {
       "name": "sell",
       "summary": "Sell a joker or consumable",
-      "description": "Sell a joker or consumable from player inventory. Must provide exactly one of: joker or consumable.",
+      "description": "Sell a joker or consumable from player inventory. Must provide exactly one of: joker or consumable. Available in SHOP, SELECTING_HAND states, and when a Buffoon pack is open (SMODS_BOOSTER_OPENED state with Joker set pack) to make room for new jokers.",
       "tags": [
         {
           "$ref": "#/components/tags/shop"
@@ -614,6 +614,9 @@
         {
           "$ref": "#/components/errors/BadRequest"
         },
+        {
+          "$ref": "#/components/errors/InvalidState"
+        },
         {
           "$ref": "#/components/errors/NotAllowed"
         }

tests/lua/endpoints/test_pack.py

@@ -158,6 +158,35 @@ def test_pack_joker_slots_full(self, client: httpx.Client) -> None:
             "Cannot select joker, joker slots are full. Current: 5, Limit: 5",
         )
 
+    def test_pack_joker_slots_full_sell_joker(self, client: httpx.Client) -> None:
+        """Test selling a joker to make room when joker slots are full during pack selection."""
+        gamestate = load_fixture(
+            client,
+            "pack",
+            "state-SMODS_BOOSTER_OPENED--pack.type-buffoon--jokers.count-5",
+        )
+        assert gamestate["jokers"]["count"] == 5
+        before_jokers = set(j["key"] for j in gamestate["jokers"]["cards"])
+        result = api(client, "sell", {"joker": 0})
+        gamestate = assert_gamestate_response(result)
+        assert gamestate["jokers"]["count"] == 4
+        result = api(client, "pack", {"card": 0})
+        gamestate = assert_gamestate_response(result, state="SHOP")
+        assert gamestate["jokers"]["count"] == 5
+        after_jokers = set(j["key"] for j in gamestate["jokers"]["cards"])
+        assert before_jokers != after_jokers
+
+    def test_pack_tarot_try_to_sell_joker(self, client: httpx.Client) -> None:
+        """Test that selling jokers is not allowed when a non-buffoon pack is open."""
+        load_fixture(
+            client, "pack", "state-SMODS_BOOSTER_OPENED--pack.cards[0].key-c_heirophant"
+        )
+        assert_error_response(
+            api(client, "sell", {"joker": 0}),
+            "NOT_ALLOWED",
+            "Can only sell jokers when a Buffoon pack is open",
+        )
+
     def test_pack_joker_slots_available(self, client: httpx.Client) -> None:
         """Test selecting joker when slots available succeeds."""
         load_fixture(