Fix tests review comment

Author: Hmnt39

ExtractorUtils.Test/unit/LoggingTest.cs

@@ -129,48 +129,51 @@ public static void TestLogLevel()
             Assert.Equal(4, sideEffect.logCount); // should not be evaluated
         }
 
-        [Theory]
-        [InlineData("console")]
-        [InlineData("file")]
-        [InlineData("trace-listener")]
-        public void TestLogger_WithDifferentLogTypes(string logType)
+        private static ServiceCollection ConfigureLoggerService(string logType, string level = null)
         {
             var services = new ServiceCollection();
+            var loggerConfig = new LoggerConfig();
 
             switch (logType)
             {
                 case "console":
-                    services.AddSingleton(new LoggerConfig
-                    {
-                        Console = new ConsoleConfig { Level = "information" }
-                    });
+                    loggerConfig.Console = new ConsoleConfig { Level = level ?? "information" };
                     break;
                 case "file":
-                    services.AddSingleton(new LoggerConfig
-                    {
-                        File = new FileConfig { Level = "warning", Path = "test.log" }
-                    });
+                    loggerConfig.File = new FileConfig { Level = level ?? "warning", Path = "test.log" };
                     break;
                 case "trace-listener":
-                    services.AddSingleton(new LoggerConfig
-                    {
-                        TraceListener = new TraceListenerConfig { Level = "error" }
-                    });
+                    loggerConfig.TraceListener = new TraceListenerConfig { Level = level ?? "error" };
                     break;
             }
+
+            services.AddSingleton(loggerConfig);
             services.AddLogger();
+            return services;
+        }
 
+        [Theory]
+        [InlineData("console")]
+        [InlineData("file")]
+        [InlineData("trace-listener")]
+        public void TestLogger_WithDifferentLogTypes(string logType)
+        {
+            var services = ConfigureLoggerService(logType);
+
+            using (var provider = services.BuildServiceProvider())
             {
-                using var provider = services.BuildServiceProvider();
                 var logger = provider.GetRequiredService<ILogger<LoggingTest>>();
 
                 Assert.NotNull(logger);
-            } // provider is disposed here
+                logger.LogWarning("Test log message");
+            } // provider is disposed here, which flushes async logs
 
-            // Cleanup test.log file if created
-            if (File.Exists("test.log"))
+            // Assert and cleanup test.log file if created by file logger
+            if (logType == "file")
             {
-                File.Delete("test.log");
+                var logFile = $"test{DateTime.Now:yyyyMMdd}.log";
+                Assert.True(File.Exists(logFile));
+                File.Delete(logFile);
             }
         }
 
@@ -181,58 +184,49 @@ public void TestLogger_WithDifferentLogTypes(string logType)
         [InlineData("trace-listener", "error")]
         public void TestLogger_WithTypeAndLevel(string configType, string level)
         {
-            var services = new ServiceCollection();
-
-            // Configure logger based on the specified type and level
-            var loggerConfig = new LoggerConfig();
-            switch (configType)
-            {
-                case "console":
-                    loggerConfig.Console = new ConsoleConfig { Level = level };
-                    break;
-                case "file":
-                    loggerConfig.File = new FileConfig { Level = level, Path = "test.log" };
-                    break;
-                case "trace-listener":
-                    loggerConfig.TraceListener = new TraceListenerConfig { Level = level };
-                    break;
-            }
-
-            services.AddSingleton(loggerConfig);
-            services.AddLogger();
+            var services = ConfigureLoggerService(configType, level);
 
+            using (var provider = services.BuildServiceProvider())
             {
-                using var provider = services.BuildServiceProvider();
                 var logger = provider.GetRequiredService<ILogger<LoggingTest>>();
-
-                // Assert logger is configured
                 Assert.NotNull(logger);
 
-                // Verify the configuration was applied
-                var retrievedConfig = provider.GetRequiredService<LoggerConfig>();
-                Assert.NotNull(retrievedConfig);
-
-                switch (configType)
+                // Verify the logger respects the configured level using side effects
+                // Note: trace-listener alone falls back to default logger, so we only verify console and file
+                if (configType != "trace-listener")
                 {
-                    case "console":
-                        Assert.NotNull(retrievedConfig.Console);
-                        Assert.Equal(level, retrievedConfig.Console.Level);
-                        break;
-                    case "file":
-                        Assert.NotNull(retrievedConfig.File);
-                        Assert.Equal(level, retrievedConfig.File.Level);
-                        break;
-                    case "trace-listener":
-                        Assert.NotNull(retrievedConfig.TraceListener);
-                        Assert.Equal(level, retrievedConfig.TraceListener.Level);
-                        break;
+                    var sideEffect = new LogSideEffect();
+                    logger.LogDebug("Debug: {SideEffect}", sideEffect);
+                    logger.LogInformation("Info: {SideEffect}", sideEffect);
+                    logger.LogWarning("Warning: {SideEffect}", sideEffect);
+                    logger.LogError("Error: {SideEffect}", sideEffect);
+
+                    // Verify only messages at or above the configured level were evaluated
+                    int expectedCount = level switch
+                    {
+                        "debug" => 4, // debug, info, warning, error
+                        "information" => 3, // info, warning, error
+                        "warning" => 2, // warning, error
+                        "error" => 1, // error only
+                        _ => 0
+                    };
+                    Assert.Equal(expectedCount, sideEffect.logCount);
+                }
+                else
+                {
+                    // For trace-listener, just verify it doesn't throw
+                    logger.LogError("Test log message");
                 }
             } // provider is disposed here
 
-            // Cleanup test.log file if created
-            if (File.Exists("test.log"))
+            // Cleanup file if created by file logger
+            if (configType == "file")
             {
-                File.Delete("test.log");
+                var logFile = $"test.log";
+                if (File.Exists(logFile))
+                {
+                    File.Delete(logFile);
+                }
             }
         }
     }