Skip to content

Commit c2b823d

Browse files
B1ueber2yahojnnes
andauthored
Fix colmap namespace in the macro support of logging. (#2733)
Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
1 parent 5f653ee commit c2b823d

File tree

1 file changed

+20
-19
lines changed

1 file changed

+20
-19
lines changed

src/colmap/util/logging.h

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,21 @@
3939
// Option checker macros. In contrast to glog, this function does not abort the
4040
// program, but simply returns false on failure.
4141
#define CHECK_OPTION_IMPL(expr) \
42-
__CheckOptionImpl(__FILE__, __LINE__, (expr), #expr)
43-
#define CHECK_OPTION(expr) \
44-
if (!__CheckOptionImpl(__FILE__, __LINE__, (expr), #expr)) { \
45-
return false; \
42+
colmap::__CheckOptionImpl(__FILE__, __LINE__, (expr), #expr)
43+
#define CHECK_OPTION(expr) \
44+
if (!colmap::__CheckOptionImpl(__FILE__, __LINE__, (expr), #expr)) { \
45+
return false; \
4646
}
47-
#define CHECK_OPTION_OP(name, op, val1, val2) \
48-
if (!__CheckOptionOpImpl(__FILE__, \
49-
__LINE__, \
50-
(val1 op val2), \
51-
val1, \
52-
val2, \
53-
#val1, \
54-
#val2, \
55-
#op)) { \
56-
return false; \
47+
#define CHECK_OPTION_OP(name, op, val1, val2) \
48+
if (!colmap::__CheckOptionOpImpl(__FILE__, \
49+
__LINE__, \
50+
(val1 op val2), \
51+
val1, \
52+
val2, \
53+
#val1, \
54+
#val2, \
55+
#op)) { \
56+
return false; \
5757
}
5858
#define CHECK_OPTION_EQ(val1, val2) CHECK_OPTION_OP(_EQ, ==, val1, val2)
5959
#define CHECK_OPTION_NE(val1, val2) CHECK_OPTION_OP(_NE, !=, val1, val2)
@@ -69,20 +69,20 @@
6969
// These macros are copied from glog/logging.h and extended to a new severity
7070
// level FATAL_THROW.
7171
#define COMPACT_GOOGLE_LOG_FATAL_THROW \
72-
LogMessageFatalThrowDefault(__FILE__, __LINE__)
72+
colmap::LogMessageFatalThrowDefault(__FILE__, __LINE__)
7373

7474
#define LOG_TO_STRING_FATAL_THROW(message) \
75-
LogMessageFatalThrowDefault(__FILE__, __LINE__, message)
75+
colmap::LogMessageFatalThrowDefault(__FILE__, __LINE__, message)
7676

7777
#define LOG_FATAL_THROW(exception) \
78-
LogMessageFatalThrow<exception>(__FILE__, __LINE__).stream()
78+
colmap::LogMessageFatalThrow<exception>(__FILE__, __LINE__).stream()
7979

8080
#define THROW_CHECK(condition) \
8181
LOG_IF(FATAL_THROW, GOOGLE_PREDICT_BRANCH_NOT_TAKEN(!(condition))) \
8282
<< "Check failed: " #condition " "
8383

8484
#define THROW_CHECK_OP(name, op, val1, val2) \
85-
CHECK_OP_LOG(name, op, val1, val2, LogMessageFatalThrowDefault)
85+
CHECK_OP_LOG(name, op, val1, val2, colmap::LogMessageFatalThrowDefault)
8686

8787
#define THROW_CHECK_EQ(val1, val2) THROW_CHECK_OP(_EQ, ==, val1, val2)
8888
#define THROW_CHECK_NE(val1, val2) THROW_CHECK_OP(_NE, !=, val1, val2)
@@ -92,7 +92,8 @@
9292
#define THROW_CHECK_GT(val1, val2) THROW_CHECK_OP(_GT, >, val1, val2)
9393

9494
#define THROW_CHECK_NOTNULL(val) \
95-
ThrowCheckNotNull(__FILE__, __LINE__, "'" #val "' Must be non NULL", (val))
95+
colmap::ThrowCheckNotNull( \
96+
__FILE__, __LINE__, "'" #val "' Must be non NULL", (val))
9697

9798
namespace colmap {
9899

0 commit comments

Comments
 (0)