fix: enforce check for require-await and remove useless async

Author: malessani

.eslintrc.json

@@ -40,6 +40,7 @@
     "no-var": "error",
     "no-param-reassign": "error",
     "prefer-const": "error",
+    "require-await": "error",
     "sort-imports": "off",
     "camelcase": "off",
     "import/named": "off",

components/composite/StepPayment/index.tsx

@@ -112,14 +112,14 @@ export const StepPayment: React.FC = () => {
 
   const { isGuest, isPaymentRequired, setPayment } = appCtx
 
-  const selectPayment: THandleClick = async ({ payment, paymentSource }) => {
+  const selectPayment: THandleClick = ({ payment, paymentSource }) => {
     if (paymentSource?.payment_methods?.paymentMethods?.length > 1) {
       setHasMultiplePaymentMethods(true)
     }
     setPayment({ payment: payment as PaymentMethodType })
   }
 
-  const autoSelectCallback = async () => {
+  const autoSelectCallback = () => {
     setAutoselected(true)
   }
 

components/data/AppProvider/utils.ts

@@ -234,7 +234,7 @@ function isBillingAddressSameAsShippingAddress({
   return true
 }
 
-export const fetchOrder = async (cl: CommerceLayerClient, orderId: string) => {
+export const fetchOrder = (cl: CommerceLayerClient, orderId: string) => {
   return cl.orders.retrieve(orderId, {
     fields: {
       orders: [

components/data/GTMProvider/index.tsx

@@ -9,9 +9,9 @@ import { LINE_ITEMS_SHOPPABLE } from "components/utils/constants"
 import { DataLayerItemProps, DataLayerProps } from "./typings"
 
 interface GTMProviderData {
-  fireAddShippingInfo: (order: Order) => Promise<void>
-  fireAddPaymentInfo: () => Promise<void>
-  firePurchase: () => Promise<void>
+  fireAddShippingInfo: (order: Order) => void
+  fireAddPaymentInfo: () => void
+  firePurchase: () => void
 }
 
 export const GTMContext = createContext<GTMProviderData | null>(null)
@@ -76,7 +76,7 @@ export const GTMProvider: React.FC<GTMProviderProps> = ({
     }
   }
 
-  const fireBeginCheckout = async (order: Order) => {
+  const fireBeginCheckout = (order: Order) => {
     const lineItems = order.line_items?.filter((line_item) => {
       return LINE_ITEMS_SHOPPABLE.includes(line_item.item_type as TypeAccepted)
     })
@@ -92,10 +92,10 @@ export const GTMProvider: React.FC<GTMProviderProps> = ({
     })
   }
 
-  const fireAddShippingInfo = async (order: Order) => {
+  const fireAddShippingInfo = (order: Order) => {
     const shipments = order?.shipments
 
-    shipments?.forEach(async (shipment) => {
+    shipments?.forEach((shipment) => {
       const lineItems = shipment.stock_line_items?.map(
         // eslint-disable-next-line @typescript-eslint/ban-ts-comment
         // @ts-ignore
@@ -115,7 +115,7 @@ export const GTMProvider: React.FC<GTMProviderProps> = ({
     })
   }
 
-  const fireAddPaymentInfo = async () => {
+  const fireAddPaymentInfo = () => {
     const lineItems = order?.line_items?.filter((line_item) => {
       return LINE_ITEMS_SHOPPABLE.includes(line_item.item_type as TypeAccepted)
     })
@@ -134,7 +134,7 @@ export const GTMProvider: React.FC<GTMProviderProps> = ({
     })
   }
 
-  const firePurchase = async () => {
+  const firePurchase = () => {
     const lineItems = order?.line_items?.filter((line_item) => {
       return LINE_ITEMS_SHOPPABLE.includes(line_item.item_type as TypeAccepted)
     })