Skip to content

Commit cd03322

Browse files
authored
Merge pull request #179 from danielberndt/patch-1
Don't decode url before encoding it again
2 parents ca71e64 + edd1f4a commit cd03322

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

lib/common.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
"use strict";
22

33
var encode = require('mdurl/encode');
4-
var decode = require('mdurl/decode');
54

65
var C_BACKSLASH = 92;
76

@@ -56,7 +55,7 @@ var unescapeString = function(s) {
5655

5756
var normalizeURI = function(uri) {
5857
try {
59-
return encode(decode(uri));
58+
return encode(uri);
6059
}
6160
catch(err) {
6261
return uri;

test/regression.txt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,15 @@ Double-encoding.
122122
```````````````````````````````` example
123123
[XSS](javascript:alert%28'XSS'%29)
124124
.
125-
<p><a href="javascript&amp;colon;alert('XSS')">XSS</a></p>
125+
<p><a href="javascript&amp;colon;alert%28'XSS'%29">XSS</a></p>
126+
````````````````````````````````
127+
128+
PR #179
129+
130+
```````````````````````````````` example
131+
[link](https://www.example.com/home/%25batty)
132+
.
133+
<p><a href="https://www.example.com/home/%25batty">link</a></p>
126134
````````````````````````````````
127135

128136
Issue commonamrk#517 - script, pre, style close tag without

0 commit comments

Comments
 (0)