Multithreaded Client

[cavemanloverboy]

Addresses #2218.

This introduces two changes.

1. Internally, it has the client library hold and accept some S: Signer + Send + Sync instead of some dyn Signer. This makes the Client (and other) types Send and Sync.
2. We change all std::rc::Rc to std::sync::Arc so that the Client (and other) types can be shared across threads. This allows builders to write multithreaded (async, parallel) codes that use an anchor_client::Client.

We also update the client/example to include a single and multithreaded test..

[vercel]

@cavemanloverboy is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

[Henry-E]

This seems cool for sure but looks like a major breaking change / a lot of rewriting will be needed by anyone using the new client? Just because it looks like almost all the functions / a bunch of types need <S> after them now. Plus I'm totally dumb and was wondering what even is S in this context. (Reading into it more it looks like S is the keypair / signer type but still haven't cleared up how it works.)

There must be a more ergonomic way to support multi thread than having to add <S: Signer + Send + Sync> in front of all functions now fn basic_2<S: Signer + Send + Sync>(client: &Client<S>, pid: Pubkey) -> Result<()> {. Or is this syntax just for functions that will support multithreading?

[Henry-E]

I think this is good to merge just two things

• please add it as a breaking change to the changelog
• Based on some CI test errors, it looks like the zero copy test uses the client and is broken, so it also needs to be updated

Hopefully we can merge and someone of the insane people who use anchor/master to dev off of can give comments on how it affects their client experience!

[cavemanloverboy]

BTW this should no longer introduce breaking changes and all tests pass

[Henry-E]

Excellent, I will review and merge. Have you added the changelog?

…

On Fri, Feb 3, 2023, 7:22 AM cavemanloverboy ***@***.***> wrote: BTW this should no longer introduce breaking changes and all tests pass — Reply to this email directly, view it on GitHub <#2321 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADAHMGD24XOAKNKVUZM7S2DWVSW3HANCNFSM6AAAAAATCJPB5Q> . You are receiving this because you commented.Message ID: ***@***.***>

[Henry-E]

I'm going to merge this before it goes on any longer but before releasing the next version of anchor it would be really helpful if you were able to write up something about how to use the new multithreaded option and whether anything needs to be changes about existing tests to use it. e.g. In the example test there's a slightly complicated type alias for the test function, should all multithreaded tests be written using such a pattern / type?