Skip to content

cli: fixes bug where the wrong exit status is reported#2370

Merged
Henry-E merged 2 commits into
otter-sec:masterfrom
RuvendeGroote:exit-status-bug
Feb 6, 2023
Merged

cli: fixes bug where the wrong exit status is reported#2370
Henry-E merged 2 commits into
otter-sec:masterfrom
RuvendeGroote:exit-status-bug

Conversation

@RuvendeGroote

Copy link
Copy Markdown

Fixes: #2117

@vercel

vercel Bot commented Jan 25, 2023

Copy link
Copy Markdown

@RuvenSalamon is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@RuvendeGroote RuvendeGroote mentioned this pull request Jan 25, 2023
Comment thread avm/src/anchor/main.rs
@Henry-E

Henry-E commented Jan 25, 2023

Copy link
Copy Markdown

Ok, so this is linked to how AVM processes CLI calls and sends them to whatever version of anchor is active.

Don't forget to add a changelog.

@RuvendeGroote

RuvendeGroote commented Jan 25, 2023

Copy link
Copy Markdown
Author

Ok, so this is linked to how AVM processes CLI calls and sends them to whatever version of anchor is active.

Don't forget to add a changelog.

Done!

@Henry-E

Henry-E commented Jan 25, 2023

Copy link
Copy Markdown

Dumb question but how can i verify / test that this doesn't just break AVM. I'm not sure if avm has tests or if the tests use avm for their CLI stuff. I only ask because I assume this is something you've tested locally in order to verify that it works?

@RuvendeGroote

RuvendeGroote commented Jan 27, 2023

Copy link
Copy Markdown
Author

Dumb question but how can i verify / test that this doesn't just break AVM. I'm not sure if avm has tests or if the tests use avm for their CLI stuff. I only ask because I assume this is something you've tested locally in order to verify that it works?

I basically compiled and ran the executable from the target dir. I do see some tests executing the anchor command in the tests dir (although it seems to use anchor from the ts package and not the avm wrapper) but no tests for avm in the avm dir.
I can add a test if you want, not sure if you'd like them in the tests folder as that seems to also function as a sort of repository of examples and this would not really be an example. I could create a tests dir in the avm dir?
I will be away during the weekend so might be slow to react. Will fix the conflict as well (unless somebody else wants to do these things)

@RuvendeGroote

Copy link
Copy Markdown
Author

(Accidentally closed the PR, misclick)

@Henry-E Henry-E marked this pull request as ready for review February 6, 2023 12:21
@Henry-E Henry-E merged commit 010b400 into otter-sec:master Feb 6, 2023
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong exit status

2 participants