Skip to content

ts: Narrow AccountClient to it's appropriate type#2440

Merged
armaniferrante merged 1 commit into
otter-sec:masterfrom
quellen-sol:fix-account-union-typing
Mar 24, 2023
Merged

ts: Narrow AccountClient to it's appropriate type#2440
armaniferrante merged 1 commit into
otter-sec:masterfrom
quellen-sol:fix-account-union-typing

Conversation

@quellen-sol

Copy link
Copy Markdown
Contributor

Problem

As described in #1706, T in AccountClient currently shows as a union of all the account types.

Changes

Use the IdlAccounts type to determine T based on a new generic N (name of the account)

@vercel

vercel Bot commented Mar 21, 2023

Copy link
Copy Markdown

@quellen-sol is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@quellen-sol quellen-sol force-pushed the fix-account-union-typing branch from f1af810 to b2bba5c Compare March 21, 2023 23:25
@quellen-sol quellen-sol changed the title Narrow AccountClient to it's appropriate type ts: Narrow AccountClient to it's appropriate type Mar 22, 2023
@quellen-sol quellen-sol force-pushed the fix-account-union-typing branch from b2bba5c to ee2d7d6 Compare March 24, 2023 04:05
@armaniferrante armaniferrante merged commit f307729 into otter-sec:master Mar 24, 2023
@quellen-sol quellen-sol deleted the fix-account-union-typing branch March 24, 2023 19:03
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants