Skip to content

Support --upgradeable-program in anchor test#2642

Merged
acheroncrypto merged 1 commit into
otter-sec:masterfrom
nickguo:anchor_test_upgradeable_program_flag
Oct 3, 2023
Merged

Support --upgradeable-program in anchor test#2642
acheroncrypto merged 1 commit into
otter-sec:masterfrom
nickguo:anchor_test_upgradeable_program_flag

Conversation

@nickguo

@nickguo nickguo commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

please advise on how to best test this change

@vercel

vercel Bot commented Sep 29, 2023

Copy link
Copy Markdown

@nickguo is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@nickguo nickguo force-pushed the anchor_test_upgradeable_program_flag branch from 8b56ed1 to 4fceec7 Compare September 29, 2023 20:24
Comment thread cli/src/lib.rs Outdated
@nickguo nickguo force-pushed the anchor_test_upgradeable_program_flag branch 3 times, most recently from 265ae11 to 2d00b48 Compare September 29, 2023 22:43
Comment thread cli/src/config.rs Outdated
Comment thread cli/src/lib.rs
@nickguo nickguo force-pushed the anchor_test_upgradeable_program_flag branch from 2d00b48 to 65032e2 Compare October 2, 2023 05:17

@acheroncrypto acheroncrypto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a couple of small issues I've mentioned.

Could you add an entry to the CHANGELOG before we merge?

Comment thread docs/src/pages/docs/manifest.md Outdated
Comment thread docs/src/pages/docs/manifest.md Outdated
@nickguo nickguo force-pushed the anchor_test_upgradeable_program_flag branch 2 times, most recently from 2ff4e67 to e42da26 Compare October 2, 2023 19:57
@nickguo nickguo requested a review from acheroncrypto October 2, 2023 19:58

@acheroncrypto acheroncrypto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict in the CHANGELOG file that blocks the merge. Could you rebase to master?

Comment thread CHANGELOG.md
@nickguo nickguo force-pushed the anchor_test_upgradeable_program_flag branch from e42da26 to c2c8ecd Compare October 2, 2023 22:45
@nickguo nickguo requested a review from acheroncrypto October 2, 2023 22:47
Comment thread cli/src/config.rs Outdated
@nickguo nickguo force-pushed the anchor_test_upgradeable_program_flag branch from c2c8ecd to f076e7d Compare October 3, 2023 13:12
@nickguo nickguo requested a review from acheroncrypto October 3, 2023 13:13
@acheroncrypto

Copy link
Copy Markdown
Collaborator

Thank you for the contribution and addressing the feedback quickly!

@acheroncrypto acheroncrypto merged commit 5602244 into otter-sec:master Oct 3, 2023
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants