Skip to content

Commit 0147347

Browse files
authored
test: fix sims (#21735)
1 parent 5909f0a commit 0147347

4 files changed

Lines changed: 36 additions & 6 deletions

File tree

.github/workflows/sims-052.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,12 @@ jobs:
9393
9494
sims-notify-success:
9595
needs:
96-
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
96+
[
97+
test-sim-multi-seed-short,
98+
test-sim-after-import,
99+
test-sim-import-export,
100+
test-sim-deterministic,
101+
]
97102
runs-on: large-sdk-runner
98103
if: ${{ success() }}
99104
steps:
@@ -120,7 +125,12 @@ jobs:
120125
permissions:
121126
contents: none
122127
needs:
123-
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
128+
[
129+
test-sim-multi-seed-short,
130+
test-sim-after-import,
131+
test-sim-import-export,
132+
test-sim-deterministic,
133+
]
124134
runs-on: large-sdk-runner
125135
if: ${{ failure() }}
126136
steps:

.github/workflows/sims.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,12 @@ jobs:
8383
8484
sims-notify-success:
8585
needs:
86-
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
86+
[
87+
test-sim-multi-seed-short,
88+
test-sim-after-import,
89+
test-sim-import-export,
90+
test-sim-deterministic,
91+
]
8792
runs-on: large-sdk-runner
8893
if: ${{ success() }}
8994
steps:
@@ -111,7 +116,12 @@ jobs:
111116
permissions:
112117
contents: none
113118
needs:
114-
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
119+
[
120+
test-sim-multi-seed-short,
121+
test-sim-after-import,
122+
test-sim-import-export,
123+
test-sim-deterministic,
124+
]
115125
runs-on: large-sdk-runner
116126
if: ${{ failure() }}
117127
steps:

server/util_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,12 @@ func (m mapGetter) Get(key string) interface{} {
493493
}
494494

495495
func (m mapGetter) GetString(key string) string {
496-
return m[key].(string)
496+
str, ok := m[key]
497+
if !ok {
498+
return ""
499+
}
500+
501+
return str.(string)
497502
}
498503

499504
var _ servertypes.AppOptions = mapGetter{}

testutils/sims/runner.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,12 @@ func (f AppOptionsFn) Get(k string) any {
236236
}
237237

238238
func (f AppOptionsFn) GetString(k string) string {
239-
return f(k).(string)
239+
str, ok := f(k).(string)
240+
if !ok {
241+
return ""
242+
}
243+
244+
return str
240245
}
241246

242247
// FauxMerkleModeOpt returns a BaseApp option to use a dbStoreAdapter instead of

0 commit comments

Comments
 (0)