style: gofumpt linting (#15605)

Author: tac0turtle

client/v2/autocli/common_test.go

@@ -49,7 +49,8 @@ func testExecCommon(t *testing.T, buildModuleCommand func(string, *Builder) (*co
 		Builder: flag.Builder{
 			GetClientConn: func() (grpc.ClientConnInterface, error) {
 				return conn, nil
-			}},
+			},
+		},
 		GetClientConn: func(*cobra.Command) (grpc.ClientConnInterface, error) {
 			return conn, nil
 		},

client/v2/autocli/query_test.go

@@ -159,7 +159,6 @@ func TestJSONParsing(t *testing.T) {
 		"-u", "27", // shorthand
 	)
 	assert.DeepEqual(t, conn.lastRequest, conn.lastResponse.(*testpb.EchoResponse).Request, protocmp.Transform())
-
 }
 
 func TestOptions(t *testing.T) {
@@ -319,7 +318,7 @@ type testClientConn struct {
 	errorOut     *bytes.Buffer
 }
 
-func (t *testClientConn) Invoke(ctx context.Context, method string, args interface{}, reply interface{}, opts ...grpc.CallOption) error {
+func (t *testClientConn) Invoke(ctx context.Context, method string, args, reply interface{}, opts ...grpc.CallOption) error {
 	err := t.ClientConn.Invoke(ctx, method, args, reply, opts...)
 	t.lastRequest = args
 	t.lastResponse = reply

collections/indexes/multi_pair.go

@@ -24,7 +24,7 @@ type pairKeyCodec[K1, K2 any] interface {
 // NewMultiPair instantiates a new MultiPair index.
 // NOTE: when using this function you will need to type hint: doing NewMultiPair[Value]()
 // Example: if the value of the indexed map is string, you need to do NewMultiPair[string](...)
-func NewMultiPair[Value any, K1, K2 any](
+func NewMultiPair[Value, K1, K2 any](
 	sb *collections.SchemaBuilder,
 	prefix collections.Prefix,
 	name string,

collections/iter.go

@@ -75,7 +75,7 @@ type Ranger[K any] interface {
 	// iteration will yield keys from the smallest to the biggest, if order
 	// is OrderDescending then the iteration will yield keys from the biggest to the smallest.
 	// Ordering is defined by the keys bytes representation, which is dependent on the KeyCodec used.
-	RangeValues() (start *RangeKey[K], end *RangeKey[K], order Order, err error)
+	RangeValues() (start, end *RangeKey[K], order Order, err error)
 }
 
 // Range is a Ranger implementer.
@@ -126,7 +126,7 @@ var (
 	errOrder = errors.New("collections: invalid order")
 )
 
-func (r *Range[K]) RangeValues() (start *RangeKey[K], end *RangeKey[K], order Order, err error) {
+func (r *Range[K]) RangeValues() (start, end *RangeKey[K], order Order, err error) {
 	return r.start, r.end, r.order, nil
 }
 

collections/iter_test.go

@@ -175,7 +175,7 @@ func TestWalk(t *testing.T) {
 	}
 
 	u := uint64(0)
-	err = m.Walk(ctx, nil, func(key uint64, value uint64) bool {
+	err = m.Walk(ctx, nil, func(key, value uint64) bool {
 		if key == 5 {
 			return true
 		}

collections/pair.go

@@ -261,7 +261,7 @@ func (p *PairRange[K1, K2]) Descending() *PairRange[K1, K2] {
 	return p
 }
 
-func (p *PairRange[K1, K2]) RangeValues() (start *RangeKey[Pair[K1, K2]], end *RangeKey[Pair[K1, K2]], order Order, err error) {
+func (p *PairRange[K1, K2]) RangeValues() (start, end *RangeKey[Pair[K1, K2]], order Order, err error) {
 	if p.err != nil {
 		return nil, nil, 0, err
 	}

crypto/keys/secp256k1/secp256k1_cgo.go

@@ -22,6 +22,6 @@ func (privKey *PrivKey) Sign(msg []byte) ([]byte, error) {
 
 // VerifySignature validates the signature.
 // The msg will be hashed prior to signature verification.
-func (pubKey *PubKey) VerifySignature(msg []byte, sigStr []byte) bool {
+func (pubKey *PubKey) VerifySignature(msg, sigStr []byte) bool {
 	return secp256k1.VerifySignature(pubKey.Bytes(), crypto.Sha256(msg), sigStr)
 }

depinject/binding_test.go

@@ -131,11 +131,11 @@ func fullTypeName(typeName string) string {
 	return fmt.Sprintf("cosmossdk.io/depinject_test/depinject_test.%s", typeName)
 }
 
-func (s *bindingSuite) ThereIsAGlobalBindingForA(preferredType string, interfaceType string) {
+func (s *bindingSuite) ThereIsAGlobalBindingForA(preferredType, interfaceType string) {
 	s.addConfig(depinject.BindInterface(fullTypeName(interfaceType), fullTypeName(preferredType)))
 }
 
-func (s *bindingSuite) ThereIsABindingForAInModule(preferredType string, interfaceType string, moduleName string) {
+func (s *bindingSuite) ThereIsABindingForAInModule(preferredType, interfaceType, moduleName string) {
 	s.addConfig(depinject.BindInterfaceInModule(moduleName, fullTypeName(interfaceType), fullTypeName(preferredType)))
 }
 
@@ -147,7 +147,7 @@ func (s *bindingSuite) ModuleWantsADuck(module string) {
 	s.addConfig(depinject.ProvideInModule(module, ProvideModuleDuck))
 }
 
-func (s *bindingSuite) ModuleResolvesA(module string, duckType string) {
+func (s *bindingSuite) ModuleResolvesA(module, duckType string) {
 	pond := s.resolvePond()
 	moduleFound := false
 	for _, dw := range pond.Ducks {

depinject/config.go

@@ -109,7 +109,7 @@ func invoke(ctr *container, key *moduleKey, invokers []interface{}) error {
 //
 //	"cosmossdk.io/depinject_test/depinject_test.Duck",
 //	"cosmossdk.io/depinject_test/depinject_test.Canvasback")
-func BindInterface(inTypeName string, outTypeName string) Config {
+func BindInterface(inTypeName, outTypeName string) Config {
 	return containerConfig(func(ctr *container) error {
 		return bindInterface(ctr, inTypeName, outTypeName, "")
 	})
@@ -125,13 +125,13 @@ func BindInterface(inTypeName string, outTypeName string) Config {
 //	 "moduleFoo",
 //		"cosmossdk.io/depinject_test/depinject_test.Duck",
 //		"cosmossdk.io/depinject_test/depinject_test.Canvasback")
-func BindInterfaceInModule(moduleName string, inTypeName string, outTypeName string) Config {
+func BindInterfaceInModule(moduleName, inTypeName, outTypeName string) Config {
 	return containerConfig(func(ctr *container) error {
 		return bindInterface(ctr, inTypeName, outTypeName, moduleName)
 	})
 }
 
-func bindInterface(ctr *container, inTypeName string, outTypeName string, moduleName string) error {
+func bindInterface(ctr *container, inTypeName, outTypeName, moduleName string) error {
 	var mk *moduleKey
 	if moduleName != "" {
 		mk = &moduleKey{name: moduleName}

depinject/internal/codegen/type.go

@@ -119,7 +119,7 @@ func (g *FileGen) TypeExpr(typ reflect.Type) (ast.Expr, error) {
 
 var genericTypeNameRegex = regexp.MustCompile(`(\w+)\[(.*)]`)
 
-func (g *FileGen) importGenericTypeParams(typeName string, pkgPath string) (newTypeName string) {
+func (g *FileGen) importGenericTypeParams(typeName, pkgPath string) (newTypeName string) {
 	// a generic type parameter from the same package the generic type is defined won't have the
 	// full package name so we need to compare it with the final package part (the default import prefix)
 	// ex: for a/b.C in package a/b, we'll just see the type param b.C.