Skip to content

Commit 647907d

Browse files
refactor(x/authz,x/feegrant): provide updated keeper in depinject (backport #20590) (#20595)
Co-authored-by: Julien Robert <julien@rbrt.fr>
1 parent 7009a2e commit 647907d

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
3737

3838
## [Unreleased]
3939

40+
## Improvements
41+
42+
* (x/authz,x/feegrant) [#20590](https://github.com/cosmos/cosmos-sdk/pull/20590) Provide updated keeper in depinject for authz and feegrant modules.
43+
4044
## [v0.47.11](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.11) - 2024-04-22
4145

4246
### Bug Fixes

x/authz/module/module.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ type AuthzOutputs struct {
192192
func ProvideModule(in AuthzInputs) AuthzOutputs {
193193
k := keeper.NewKeeper(in.Key, in.Cdc, in.MsgServiceRouter, in.AccountKeeper)
194194
m := NewAppModule(in.Cdc, k, in.AccountKeeper, in.BankKeeper, in.Registry)
195-
return AuthzOutputs{AuthzKeeper: k, Module: m}
195+
return AuthzOutputs{AuthzKeeper: k.SetBankKeeper(in.BankKeeper) /* depinject ux improvement */, Module: m}
196196
}
197197

198198
// ____________________________________________________________________________

x/feegrant/module/module.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ type AppModule struct {
121121
func NewAppModule(cdc codec.Codec, ak feegrant.AccountKeeper, bk feegrant.BankKeeper, keeper keeper.Keeper, registry cdctypes.InterfaceRegistry) AppModule {
122122
return AppModule{
123123
AppModuleBasic: AppModuleBasic{cdc: cdc},
124-
keeper: keeper.SetBankKeeper(bk), // Super ugly hack to not be api breaking in v0.50 and v0.47,
124+
keeper: keeper.SetBankKeeper(bk), // Super ugly hack to not be api breaking in v0.50 and v0.47
125125
accountKeeper: ak,
126126
bankKeeper: bk,
127127
registry: registry,
@@ -197,7 +197,7 @@ type FeegrantInputs struct {
197197
func ProvideModule(in FeegrantInputs) (keeper.Keeper, appmodule.AppModule) {
198198
k := keeper.NewKeeper(in.Cdc, in.Key, in.AccountKeeper)
199199
m := NewAppModule(in.Cdc, in.AccountKeeper, in.BankKeeper, k, in.Registry)
200-
return k, m
200+
return k.SetBankKeeper(in.BankKeeper) /* depinject ux improvement */, m
201201
}
202202

203203
// AppModuleSimulation functions

0 commit comments

Comments
 (0)