feedback

Author: julienrbrt

client/v2/internal/util/util.go

@@ -63,6 +63,8 @@ func isSupportedVersion(input string, buildInfo *debug.BuildInfo) bool {
 	return true // if cannot find the module consider it's supported
 }
 
+var sinceCommentRegex = regexp.MustCompile(`\/\/\s*since: (\S+) (\S+)`)
+
 // parseSinceComment parses the `// Since: cosmos-sdk v0.xx` comment on rpc.
 func parseSinceComment(input string) (string, string) {
 	var (
@@ -73,12 +75,11 @@ func parseSinceComment(input string) (string, string) {
 	input = strings.ToLower(input)
 	input = strings.ReplaceAll(input, "cosmos sdk", "cosmos-sdk")
 
-	re := regexp.MustCompile(`\/\/\s*since: (\S+) (\S+)`)
-	matches := re.FindStringSubmatch(input)
+	matches := sinceCommentRegex.FindStringSubmatch(input)
 	if len(matches) >= 3 {
 		moduleName, version = matches[1], matches[2]
 
-		if !strings.Contains(version, "v") {
+		if !strings.HasPrefix(version, "v") {
 			version = "v" + version
 		}
 	}

client/v2/internal/util/util_test.go

@@ -132,6 +132,11 @@ func TestParseSinceComment(t *testing.T) {
 			expectedModuleName: "cosmos-sdk",
 			expectedVersion:    "v0.50.1",
 		},
+		{
+			input:              "// since: cosmos-sdk 0.47.0-veronica",
+			expectedModuleName: "cosmos-sdk",
+			expectedVersion:    "v0.47.0-veronica",
+		},
 		{
 			input:              "// Since: x/feegrant v0.1.0",
 			expectedModuleName: "x/feegrant",