fix: concurrent map writes when calling GetSigners

Author: facundomedica

simapp/app.go

@@ -603,6 +603,11 @@ func NewSimApp(
 		}
 	}
 
+	// validate SigningContext to pre-fill internal signers funcs map
+	if err = app.interfaceRegistry.SigningContext().Validate(); err != nil {
+		panic(err)
+	}
+
 	return app
 }
 

x/tx/signing/context.go

@@ -3,6 +3,7 @@ package signing
 import (
 	"errors"
 	"fmt"
+	"sync"
 
 	cosmos_proto "github.com/cosmos/cosmos-proto"
 	gogoproto "github.com/cosmos/gogoproto/proto"
@@ -29,9 +30,11 @@ type Context struct {
 	typeResolver          protoregistry.MessageTypeResolver
 	addressCodec          address.Codec
 	validatorAddressCodec address.Codec
-	getSignersFuncs       map[protoreflect.FullName]GetSignersFunc
 	customGetSignerFuncs  map[protoreflect.FullName]GetSignersFunc
 	maxRecursionDepth     int
+
+	mtx             sync.Mutex
+	getSignersFuncs map[protoreflect.FullName]GetSignersFunc
 }
 
 // Options are options for creating Context which will be used for signing operations.
@@ -110,6 +113,7 @@ func NewContext(options Options) (*Context, error) {
 		typeResolver:          protoTypes,
 		addressCodec:          options.AddressCodec,
 		validatorAddressCodec: options.ValidatorAddressCodec,
+		mtx:                   sync.Mutex{},
 		getSignersFuncs:       map[protoreflect.FullName]GetSignersFunc{},
 		customGetSignerFuncs:  customGetSignerFuncs,
 		maxRecursionDepth:     options.MaxRecursionDepth,
@@ -336,6 +340,8 @@ func (c *Context) getGetSignersFn(messageDescriptor protoreflect.MessageDescript
 	}
 	f, ok = c.getSignersFuncs[messageDescriptor.FullName()]
 	if !ok {
+		c.mtx.Lock()
+		defer c.mtx.Unlock()
 		var err error
 		f, err = c.makeGetSignersFunc(messageDescriptor)
 		if err != nil {