fix(x/group): proper address rendering in error (#22425)

julienrbrt · web-flow · commit 8c24b6bef1f7 · 2024-11-05T09:02:47.000Z
diff --git a/x/group/keeper/proposal_executor.go b/x/group/keeper/proposal_executor.go
@@ -70,7 +70,13 @@ func ensureMsgAuthZ(msgs []sdk.Msg, groupPolicyAcc sdk.AccAddress, cdc codec.Cod
 				if err != nil {
 					return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; error retrieving group policy address")
 				}
-				return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAddr, acct)
+
+				acctStr, _ := addressCodec.BytesToString(acct)
+				if acctStr == "" {
+					acctStr = "unmarshalable address"
+				}
+
+				return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAddr, acctStr)
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,13 @@ func ensureMsgAuthZ(msgs []sdk.Msg, groupPolicyAcc sdk.AccAddress, cdc codec.Cod`
`70`	`70`	`if err != nil {`
`71`	`71`	`return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; error retrieving group policy address")`
`72`	`72`	`}`
`73`		`- return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAddr, acct)`
	`73`	`+`
	`74`	`+ acctStr, _ := addressCodec.BytesToString(acct)`
	`75`	`+ if acctStr == "" {`
	`76`	`+ acctStr = "unmarshalable address"`
	`77`	`+ }`
	`78`	`+`
	`79`	`+ return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAddr, acctStr)`
`74`	`80`	`}`
`75`	`81`	`}`
`76`	`82`	`}`