Skip to content

Commit aeb1e8f

Browse files
authored
refactor(x/authz,x/feegrant): provide updated keeper in depinject (#20590)
1 parent d8bfb8a commit aeb1e8f

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
3838

3939
## [Unreleased]
4040

41+
## Improvements
42+
43+
* (x/authz,x/feegrant) [#20590](https://github.com/cosmos/cosmos-sdk/pull/20590) Provide updated keeper in depinject for authz and feegrant modules.
44+
4145
## [v0.50.7](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.50.7) - 2024-06-04
4246

4347
### Improvements

x/authz/module/module.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ type ModuleOutputs struct {
178178
func ProvideModule(in ModuleInputs) ModuleOutputs {
179179
k := keeper.NewKeeper(in.StoreService, in.Cdc, in.MsgServiceRouter, in.AccountKeeper)
180180
m := NewAppModule(in.Cdc, k, in.AccountKeeper, in.BankKeeper, in.Registry)
181-
return ModuleOutputs{AuthzKeeper: k, Module: m}
181+
return ModuleOutputs{AuthzKeeper: k.SetBankKeeper(in.BankKeeper) /* depinject ux improvement */, Module: m}
182182
}
183183

184184
// ____________________________________________________________________________

x/feegrant/module/module.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ type AppModule struct {
120120
func NewAppModule(cdc codec.Codec, ak feegrant.AccountKeeper, bk feegrant.BankKeeper, keeper keeper.Keeper, registry cdctypes.InterfaceRegistry) AppModule {
121121
return AppModule{
122122
AppModuleBasic: AppModuleBasic{cdc: cdc, ac: ak.AddressCodec()},
123-
keeper: keeper.SetBankKeeper(bk),
123+
keeper: keeper.SetBankKeeper(bk), // Super ugly hack to not be api breaking in v0.50 and v0.47
124124
accountKeeper: ak,
125125
bankKeeper: bk,
126126
registry: registry,
@@ -184,7 +184,7 @@ type FeegrantInputs struct {
184184
func ProvideModule(in FeegrantInputs) (keeper.Keeper, appmodule.AppModule) {
185185
k := keeper.NewKeeper(in.Cdc, in.StoreService, in.AccountKeeper)
186186
m := NewAppModule(in.Cdc, in.AccountKeeper, in.BankKeeper, k, in.Registry)
187-
return k, m
187+
return k.SetBankKeeper(in.BankKeeper) /* depinject ux improvement */, m
188188
}
189189

190190
// AppModuleSimulation functions

0 commit comments

Comments
 (0)