add category tags#4049
Merged
Merged
Conversation
fedekunze
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
suggested changes
Apr 5, 2019
alexanderbez
left a comment
alexanderbez
left a comment
Contributor
There was a problem hiding this comment.
One small nit, otherwise LGTM.
alexanderbez
approved these changes
Apr 5, 2019
jackzampolin
approved these changes
Apr 8, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4049 +/- ##
===========================================
+ Coverage 59.95% 59.95% +<.01%
===========================================
Files 212 212
Lines 15104 15122 +18
===========================================
+ Hits 9056 9067 +11
- Misses 5426 5433 +7
Partials 622 622 |
fedekunze
added
the
T: API Breaking
alessio
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3774
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: