R4R: Remove dep and vendor from doc and version.#4064
Merged
alexanderbez merged 11 commits intoApr 8, 2019
Conversation
yangyanqing
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #4064 +/- ##
===========================================
- Coverage 60.01% 59.99% -0.02%
===========================================
Files 212 212
Lines 15107 15107
===========================================
- Hits 9066 9064 -2
- Misses 5420 5422 +2
Partials 621 621 |
Codecov Report
@@ Coverage Diff @@
## develop #4064 +/- ##
===========================================
+ Coverage 60.01% 60.02% +0.01%
===========================================
Files 212 212
Lines 15107 15107
===========================================
+ Hits 9066 9068 +2
+ Misses 5420 5418 -2
Partials 621 621 |
alessio
suggested changes
Apr 6, 2019
alessio
left a comment
alessio
left a comment
Contributor
There was a problem hiding this comment.
go.sum hashsum is no-go - at least until we introduce reproducible builds.
Contributor
Author
|
Thank you for your careful review! @alessio |
alessio
reviewed
Apr 6, 2019
alessio
left a comment
alessio
left a comment
Contributor
There was a problem hiding this comment.
GoModHash should be GoSumHash
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: