Skip to content

remove duplicated account check and test#4068

Merged
alessio merged 7 commits into
developfrom
fedekunze/3426-fix-gen-only-keybase
Apr 10, 2019
Merged

remove duplicated account check and test#4068
alessio merged 7 commits into
developfrom
fedekunze/3426-fix-gen-only-keybase

Conversation

@fedekunze

@fedekunze fedekunze commented Apr 8, 2019

Copy link
Copy Markdown
Contributor
  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze changed the title fix generate-only keybase requirement fix CLI generate-only keybase requirement Apr 8, 2019
@alexanderbez

Copy link
Copy Markdown
Contributor

Apologies @fedekunze, but I think #3960 addressed this. Can you verify?

@fedekunze fedekunze changed the title fix CLI generate-only keybase requirement remove duplicated account check and test Apr 8, 2019
@codecov

codecov Bot commented Apr 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4068 into develop will decrease coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4068      +/-   ##
===========================================
- Coverage    60.01%   59.83%   -0.18%     
===========================================
  Files          212      212              
  Lines        15107    15158      +51     
===========================================
+ Hits          9066     9070       +4     
- Misses        5420     5444      +24     
- Partials       621      644      +23

@fedekunze fedekunze marked this pull request as ready for review April 8, 2019 17:07
Comment thread .pending/improvements/gaiacli/3426-remove-redundant-account-check Outdated
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
@alessio alessio merged commit eb51a6f into develop Apr 10, 2019
@alessio alessio deleted the fedekunze/3426-fix-gen-only-keybase branch April 10, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants