R4R: Fix incorrect $GOBIN in Install Go.

[yangyanqing]

• Targeted PR against correct branch (see CONTRIBUTING.md)

This bug was fixed by #3975, and broken by #4089

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added a relevant changelog entry: sdkch add [section] [stanza] [message]
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #4113 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4113      +/-   ##
===========================================
- Coverage    59.97%   59.96%   -0.02%     
===========================================
  Files          211      211              
  Lines        15111    15111              
===========================================
- Hits          9063     9061       -2     
- Misses        5428     5430       +2     
  Partials       620      620

[codecov]

Codecov Report

Merging #4113 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4113      +/-   ##
===========================================
- Coverage    59.97%   59.96%   -0.02%     
===========================================
  Files          211      211              
  Lines        15111    15111              
===========================================
- Hits          9063     9061       -2     
- Misses        5428     5430       +2     
  Partials       620      620

[alexanderbez]

Thanks @yangyanqing. Are the invalid changes present on release/v0.34.0 or only on develop? If they're on release/v0.34.0, this PR should be targeted against that branch as we haven't released yet.

[alexanderbez]

Thanks @yangyanqing. Are the invalid changes present on release/v0.34.0 or only on develop? If they're on release/v0.34.0, this PR should be targeted against that branch as we haven't released yet.

[yangyanqing]

The invalid changes were present on release/v0.34.0 too.
Should I create another PR to fix release/v0.34.0 ?
@alexanderbez

[alexanderbez]

@yangyanqing 0.34 has just been merged/released, so this PR is fine as-is. Thanks!

[alexanderbez]

Why do we need \ prefixes?

[yangyanqing]

In bash shell, variable in "" would be extended. The first version of cosmos docs was:

echo "export GOPATH=$HOME/go" >> ~/.bash_profile
source ~/.bash_profile
echo "export GOBIN=$GOPATH/bin" >> ~/.bash_profile
source ~/.bash_profile
echo "export PATH=$PATH:$GOBIN" >> ~/.bash_profile
source ~/.bash_profile

After source ~/.bash_profile, variable which was export just now was extended in current shell. So echo "export GOBIN=$GOPATH/bin" >> ~/.bash_profile was extended to echo "export GOBIN=/home/alice/go/bin" >> ~/.bash_profile. Otherwise it would be extended to echo "export GOBIN=/bin" >> ~/.bash_profile.

After executing all steps in first version, we got ~/.bash_profile :

......
export GOPATH=/home/alice/go
export GOBIN=/home/alice/go/bin
export PATH=/usr/bin/:usr/local/bin:......:/home/alice/go/bin

After executing all steps in current version, we got ~/.bash_profile :

......
export GOPATH=/home/alice/go
export GOBIN=/bin
export PATH=/usr/bin/:usr/local/bin:......:/bin

After executing all steps in PR version, we got ~/.bash_profile :

......
export GOPATH=/home/alice/go
export GOBIN=$GOPATH/bin
export PATH=$PATH:$GOBIN

We also can modify as following because variables in '' would not be extended.

mkdir -p $HOME/go/bin
echo 'export GOPATH=$HOME/go' >> ~/.bash_profile
echo 'export GOBIN=$GOPATH/bin' >> ~/.bash_profile
echo 'export PATH=$PATH:$GOBIN' >> ~/.bash_profile
source ~/.bash_profile

Choosing prefix \ for keeping pace with other docs.

[alessio]

In all honestly, I prefer the single-quote syntax

[yangyanqing]

I like single-quote too. @alessio