Adding support for Ledger Cosmos App v1.5#4227
Merged
Merged
Conversation
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
jleni
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
jleni
added
C:CLI
C:Ledger
Contributor
|
should we block this PR until LedgerHQ/ledger-app-cosmos#5 is merged ? |
fedekunze
reviewed
Apr 29, 2019
Contributor
Author
It should be backwards compatible. It uses old APIs if the app version number is <1.5. |
fedekunze
suggested changes
Apr 29, 2019
fedekunze
left a comment
fedekunze
left a comment
Contributor
There was a problem hiding this comment.
tested ACK, although there's an UX issue if the address is rejected
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
Co-Authored-By: jleni <juan.leni@zondax.ch>
alexanderbez
suggested changes
Apr 29, 2019
alexanderbez
left a comment
alexanderbez
left a comment
Contributor
There was a problem hiding this comment.
TestedACK -- just a few minor bits of feedback. Thanks @jleni
Co-Authored-By: jleni <juan.leni@zondax.ch>
Contributor
Author
|
applied all the suggestions |
alexanderbez
approved these changes
Apr 30, 2019
alessio
approved these changes
Apr 30, 2019
This was referenced May 21, 2019
Merged
alexanderbez
pushed a commit
that referenced
this pull request
May 23, 2019
alexanderbez
added a commit
that referenced
this pull request
May 23, 2019
* Cherry Pick PR #4345: Upgrade ledger-cosmos-go * Cherry Pick PR #4336: Fix AppendTags usage error * Update modules * Cherry Pick PR #4265: CacheKVStore keep sorted items * Cherry Pick #4227: Adding support for Ledger Cosmos App v1.5 * Cherry Pick #4395: Improve sig verification error message * Cherry Pick PR #4140: Fix Failed Simulation Seeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the latest version of the Cosmos App (v.1.5)
Attention: The app is not been released yet by Ledger but the PR is backwards compatible.
We can later remove backwards compatibility and enforce v1.5 only.
When creating a new account,
gaiaclinow shows the account/index and address in the device and requires user confirmation.Related PRs:
cosmos/ledger-cosmos-go#3
cosmos/ledger-cosmos-go#4
cosmos/ledger-cosmos-go#5
cosmos/ledger-cosmos-go#6
Changes in the app can be found here:
LedgerHQ/ledger-app-cosmos#5
docs/)sdkch add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: