R4R: gaiakeyutil -> gaiacli keys parse#4228
Merged
Merged
Conversation
Incorporate gaiakeyutil functionalities into gaiacli.
Codecov Report
@@ Coverage Diff @@
## master #4228 +/- ##
==========================================
+ Coverage 60.16% 60.24% +0.07%
==========================================
Files 212 213 +1
Lines 15188 15250 +62
==========================================
+ Hits 9138 9187 +49
- Misses 5421 5432 +11
- Partials 629 631 +2 |
fedekunze
suggested changes
Apr 29, 2019
Co-Authored-By: alessio <quadrispro@ubuntu.com>
Co-Authored-By: alessio <quadrispro@ubuntu.com>
Co-Authored-By: alessio <quadrispro@ubuntu.com>
fedekunze
reviewed
Apr 30, 2019
fedekunze
left a comment
Contributor
There was a problem hiding this comment.
LGTM, although do we want to add a test case for the CLI and update the docs too ?
Contributor
Author
|
@fedekunze this small utility hadn't made it into docs back then - I'm planning to incorporate |
fedekunze
reviewed
Apr 30, 2019
Co-Authored-By: alessio <quadrispro@ubuntu.com>
fedekunze
approved these changes
Apr 30, 2019
alexanderbez
approved these changes
Apr 30, 2019
added 2 commits
April 30, 2019 20:53
…-sdk into alessio/remove-gaiakeyutil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate
gaiakeyutilfunctionalities into gaiacli.We would neither build nor install
gaiakeyutilanymore, key string simple parsing functionality would be merged intogaiacli keys parse.This is a call for a preliminary review, pending entry will eventually be added.
docs/)sdkch add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: