Skip to content

Update go to 1.12.5#4343

Merged
alexanderbez merged 2 commits into
masterfrom
alessio/golang-1.12.5
May 15, 2019
Merged

Update go to 1.12.5#4343
alexanderbez merged 2 commits into
masterfrom
alessio/golang-1.12.5

Conversation

@alessio

@alessio alessio commented May 15, 2019

Copy link
Copy Markdown
Contributor
  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio marked this pull request as ready for review May 15, 2019 14:39
@alessio alessio requested review from fedekunze and sabau May 15, 2019 14:39

@alexanderbez alexanderbez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it. ACK

@codecov

codecov Bot commented May 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4343 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4343      +/-   ##
==========================================
- Coverage   59.38%   59.37%   -0.02%     
==========================================
  Files         214      214              
  Lines       14533    14533              
==========================================
- Hits         8631     8629       -2     
- Misses       5264     5266       +2     
  Partials      638      638

@alexanderbez alexanderbez merged commit 805de8b into master May 15, 2019
@alexanderbez alexanderbez deleted the alessio/golang-1.12.5 branch May 15, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants