Stop throwing 404's when another exception occurred

Author: brandonkelly

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Fixed
 - Fixed an “Header may not contain more than a single header” error that could occur if a different exception had occurred. ([#115](https://github.com/craftcms/element-api/issues/115))
+- Fixed a bug where most exceptions were resulting in 404 responses rather than 500s.
 
 ## 2.8.0 - 2021-08-31
 

src/controllers/DefaultController.php

@@ -27,7 +27,6 @@
 use yii\base\UserException;
 use yii\web\HttpException;
 use yii\web\JsonResponseFormatter;
-use yii\web\NotFoundHttpException;
 use yii\web\Response;
 
 /**
@@ -54,7 +53,6 @@ class DefaultController extends Controller
      * @param string $pattern The endpoint URL pattern that was matched
      * @return Response
      * @throws InvalidConfigException
-     * @throws NotFoundHttpException
      */
     public function actionIndex(string $pattern): Response
     {
@@ -78,13 +76,7 @@ public function actionIndex(string $pattern): Response
             if (is_callable($config)) {
                 /** @phpstan-ignore-next-line */
                 $params = Craft::$app->getUrlManager()->getRouteParams();
-                try {
-                    $config = $this->_callWithParams($config, $params);
-                } catch (InvalidConfigException $e) {
-                    Craft::warning("Unable to resolve Element API route: {$e->getMessage()}", __METHOD__);
-                    Craft::$app->getErrorHandler()->logException($e);
-                    throw new NotFoundHttpException('Page not found', 0, $e);
-                }
+                $config = $this->_callWithParams($config, $params);
             }
 
             if (is_array($config)) {
@@ -100,7 +92,7 @@ public function actionIndex(string $pattern): Response
                 ArrayHelper::remove($config, 'cache', true) &&
                 !($this->request->getIsPreview() || $this->request->getIsLivePreview())
             );
-            
+
             $cacheKey = ArrayHelper::remove($config, 'cacheKey')
                 ?? implode(':', [
                     'elementapi',
@@ -145,11 +137,7 @@ public function actionIndex(string $pattern): Response
             Craft::$app->getConfig()->getGeneral()->generateTransformsBeforePageLoad = true;
 
             // Get the data resource
-            try {
-                $resource = $plugin->createResource($config);
-            } catch (\Throwable $e) {
-                throw new NotFoundHttpException($e->getMessage() ?: Craft::t('element-api', 'Resource not found'), 0, $e);
-            }
+            $resource = $plugin->createResource($config);
 
             // Load Fractal
             $fractal = new Manager();