Skip to content

Commit 213b84f

Browse files
sebrandon1claude
authored andcommitted
Issue #5088 Add developer-password cleanup to @cleanup tag handler
The @cleanup handler unsets config properties like memory and preset after e2e scenarios, but was missing developer-password. This could leak a custom password into subsequent tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 463dc75 commit 213b84f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

test/e2e/testsuite/testsuite.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,12 @@ func InitializeScenario(s *godog.ScenarioContext) {
305305
os.Exit(1)
306306
}
307307

308+
err = crcCmd.UnsetConfigPropertySucceedsOrFails("developer-password", "succeeds") // unsetting property that is not set gives 0 exitcode, so this works
309+
if err != nil {
310+
fmt.Println(err)
311+
os.Exit(1)
312+
}
313+
308314
if runtime.GOOS == "linux" {
309315
err = crcCmd.UnsetConfigPropertySucceedsOrFails("network-mode", "succeeds") // unsetting property that is not set gives 0 exitcode, so this works
310316
if err != nil {

0 commit comments

Comments
 (0)