Skip to content

Commit 294eca3

Browse files
committed
fix: resolve lint warnings and comparison issue
1 parent 40f487b commit 294eca3

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

onnxscript/function_libs/torch_lib/ops/core.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3119,9 +3119,7 @@ def aten_embedding_bag_padding_idx(
31193119
weight,
31203120
indices,
31213121
offsets,
3122-
scale_grad_by_freq,
31233122
mode,
3124-
sparse,
31253123
per_sample_weights,
31263124
include_last_offset,
31273125
padding_idx,
@@ -3134,9 +3132,7 @@ def aten_embedding_bag_padding_idx(
31343132
weight,
31353133
indices,
31363134
offsets,
3137-
scale_grad_by_freq,
31383135
mode,
3139-
sparse,
31403136
per_sample_weights,
31413137
include_last_offset,
31423138
)

tests/function_libs/torch_lib/ops_test_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,9 @@ def xfail(
188188
def _embedding_bag_input_wrangler(
189189
args: list[Any], kwargs: dict[str, Any]
190190
) -> tuple[list[Any], dict[str, Any]]:
191-
# ONNX attributes cannot be None; omit padding_idx if its None.
191+
# ONNX attributes cannot be None; omit padding_idx if it's None.
192192
padding_idx = kwargs.pop("padding_idx", "___MISSING___")
193-
if padding_idx is not "___MISSING___":
193+
if padding_idx != "___MISSING___":
194194
if padding_idx is not None:
195195
kwargs["padding_idx"] = int(padding_idx)
196196

0 commit comments

Comments
 (0)