Etherscan: Add a new check that the source code is verified (#646)

* Add a new check that the source code is verified

* tests: add etherscan and sourcify tests for contract with no code

---------

Co-authored-by: Emilio López <emilio.lopez@trailofbits.com>

Author: smonicas

crytic_compile/platform/etherscan.py

@@ -383,6 +383,11 @@ def compile(self, crytic_compile: "CryticCompile", **kwargs: str) -> None:
                 raise InvalidCompilation("Contract has no public source code: " + etherscan_url)
 
             result = info["result"][0]
+
+            if "ABI" in result and "Contract source code not verified" in result["ABI"]:
+                LOGGER.error("Contract has no public source code")
+                raise InvalidCompilation("Contract has no public source code: " + etherscan_url)
+
             # Assert to help mypy
             assert isinstance(result["SourceCode"], str)
             assert isinstance(result["ContractName"], str)

scripts/ci_test_etherscan.sh

@@ -101,3 +101,12 @@ fi
 cd ../../../
 
 echo "::endgroup::"
+
+# test with no verified code - should fail
+echo "::group::Etherscan #9"
+if crytic-compile 0xc3898ea7e322b3cdc92d65cfe5a34808b7338236 --compile-remove-metadata --etherscan-apikey "$ETHERSCAN_API_KEY"
+then
+    echo "Etherscan #9 test failed"
+    exit 255
+fi
+echo "::endgroup::"

scripts/ci_test_sourcify.sh

@@ -95,6 +95,15 @@ cd ../../../
 
 echo "::endgroup::"
 
+# Same as Etherscan #9 - test with no verified code - should fail
+echo "::group::Sourcify #9"
+if crytic-compile "sourcify-1:0xc3898ea7e322b3cdc92d65cfe5a34808b7338236"
+then
+    echo "Sourcify #9 test failed"
+    exit 255
+fi
+echo "::endgroup::"
+
 # Test hex chain ID format (Sourcify-specific feature)
 echo "::group::Sourcify hex chain ID"
 if ! crytic-compile "sourcify-0x1:0x7F37f78cBD74481E593F9C737776F7113d76B315" --compile-remove-metadata