make auto-complete of createUseStyles value work#1454
Merged
kof merged 1 commit intocssinjs:masterfrom Feb 20, 2021
k-yle:ts-auto-complete
Merged
make auto-complete of createUseStyles value work#1454kof merged 1 commit intocssinjs:masterfrom k-yle:ts-auto-complete
kof merged 1 commit intocssinjs:masterfrom
k-yle:ts-auto-complete
Conversation
moshest
approved these changes
Feb 19, 2021
Member
moshest
left a comment
moshest
left a comment
There was a problem hiding this comment.
Nice hack.
Worth mention this fix is related to microsoft/TypeScript#29729
Member
|
merged, thank you |
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding issue (if exists):
Closes #1439, Closes #1452, Closes #806, possibly fixes #776
What would you like to add/fix?
Make auto-complete work for Typescript and/or VSCode users like in this screenshot:
This is not a breaking change. In the example above, folks can still type
display: "dhgjdkfhg"and TS will accept it. This PR only makes auto-complete work. It deliberately doesn't add type-safety because that needs to wait for a semver-major release.Todo