Improve performance for dynamic styles

lttb · lttb · commit 2186ef68d157 · 2017-04-23T22:19:54.000+03:00
diff --git a/src/index.js b/src/index.js
@@ -63,18 +63,19 @@ const createStyled = (jss?: Function = jssDefault) => (baseStyles: Object = {})
         }
 
         if (dynamicStyles && !dynamicSheet.getRule(this.tagScoped)) {
-          dynamicSheet.addRule(this.tagScoped, dynamicStyles)
+          dynamicSheet
+            .detach()
+            .addRule(this.tagScoped, dynamicStyles)
           dynamicSheet
             .update(this.tagScoped, this.props)
-            .deploy()
+            .attach()
+            .link()
         }
       }
 
       componentWillReceiveProps(nextProps: StyledElementPropsType) {
         if (dynamicStyles) {
-          dynamicSheet
-            .update(this.tagScoped, nextProps)
-            .deploy()
+          dynamicSheet.update(this.tagScoped, nextProps)
         }
       }
 

Original file line number	Diff line number	Diff line change
`@@ -63,18 +63,19 @@ const createStyled = (jss?: Function = jssDefault) => (baseStyles: Object = {})`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`if (dynamicStyles && !dynamicSheet.getRule(this.tagScoped)) {`
`66`		`- dynamicSheet.addRule(this.tagScoped, dynamicStyles)`
	`66`	`+ dynamicSheet`
	`67`	`+ .detach()`
	`68`	`+ .addRule(this.tagScoped, dynamicStyles)`
`67`	`69`	`dynamicSheet`
`68`	`70`	`.update(this.tagScoped, this.props)`
`69`		`- .deploy()`
	`71`	`+ .attach()`
	`72`	`+ .link()`
`70`	`73`	`}`
`71`	`74`	`}`
`72`	`75`
`73`	`76`	`componentWillReceiveProps(nextProps: StyledElementPropsType) {`
`74`	`77`	`if (dynamicStyles) {`
`75`		`- dynamicSheet`
`76`		`- .update(this.tagScoped, nextProps)`
`77`		`- .deploy()`
	`78`	`+ dynamicSheet.update(this.tagScoped, nextProps)`
`78`	`79`	`}`
`79`	`80`	`}`
`80`	`81`