Get rid from dynamicStyleSheet, fix nested dynamic rules#24
Merged
Conversation
… rules classes/rules
lttb
force-pushed
the
feature/nested
branch
2 times, most recently
from
0da963a to
ed2edc8
Compare
kof
reviewed
May 28, 2017
| sheet = jss.createStyleSheet(baseStyles, { | ||
| link: true, | ||
| meta: 'DynamicComponentSheet', | ||
| meta: 'sheet', |
Member
There was a problem hiding this comment.
this isn't saying a lot, maybe at least use : 'styled-jss'
kof
reviewed
May 28, 2017
|
|
||
| // $FlowIgnore | ||
| generateTagName.mockImplementation((tagName: string) => `${tagName}-${++styledCounter}`) | ||
| generateClassName.mockImplementation(rule => `${rule.name}-${++jssCounter}`) |
Member
There was a problem hiding this comment.
why do you mock it? Maybe you want to remove dynamic part in it so that tests don't break that often
Member
Author
There was a problem hiding this comment.
counter is important for styled-jss, because it shows an ordering of mounting, but for jss it may be static really
kof
reviewed
May 28, 2017
| const wrapper = mount(<App />) | ||
| const sheet = styled.mountSheet() | ||
|
|
||
| expect(sheet.toString()).toBe(stripIndent` |
Member
There was a problem hiding this comment.
why not to use .toMatchSnapshot() everywhere?
kof
approved these changes
May 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.