chore(cubestore): Add tracing for analysis and optimization pass

Author: srh

Cargo.lock

@@ -52,6 +52,7 @@ log = { workspace = true }
 recursive = { workspace = true, optional = true }
 regex = { workspace = true }
 regex-syntax = "0.8.0"
+tracing = { workspace = true }
 
 [dev-dependencies]
 async-trait = { workspace = true }

datafusion/optimizer/Cargo.toml

@@ -140,6 +140,9 @@ impl Analyzer {
     where
         F: FnMut(&LogicalPlan, &dyn AnalyzerRule),
     {
+        let analyzer_span = tracing::trace_span!("logical_plan_analyzer");
+        let _guard = analyzer_span.enter();
+
         // verify the logical plan required invariants at the start, before analyzer
         plan.check_invariants(InvariantLevel::Always)
             .map_err(|e| e.context("Invalid input plan passed to Analyzer"))?;
@@ -165,6 +168,8 @@ impl Analyzer {
 
         // TODO add common rule executor for Analyzer and Optimizer
         for rule in rules {
+            let rule_span = tracing::trace_span!("analyze", name = rule.name());
+            let _rule_span_guard = rule_span.enter();
             new_plan = rule
                 .analyze(new_plan, config)
                 .map_err(|e| e.context(rule.name()))?;

datafusion/optimizer/src/analyzer/mod.rs

@@ -356,6 +356,9 @@ impl Optimizer {
     where
         F: FnMut(&LogicalPlan, &dyn OptimizerRule),
     {
+        let span = tracing::trace_span!("optimize");
+        let _span_guard = span.enter();
+
         // verify LP is valid, before the first LP optimizer pass.
         plan.check_invariants(InvariantLevel::Executable)
             .map_err(|e| e.context("Invalid input plan before LP Optimizers"))?;
@@ -373,7 +376,13 @@ impl Optimizer {
         while i < options.optimizer.max_passes {
             log_plan(&format!("Optimizer input (pass {i})"), &new_plan);
 
+            let optimizer_pass_span = tracing::trace_span!("pass", number = i);
+            let _optimizer_pass_span_guard = optimizer_pass_span.enter();
+
             for rule in &self.rules {
+                let rule_span = tracing::trace_span!("rule", name = rule.name());
+                let _rule_span_guard = rule_span.enter();
+
                 // If skipping failed rules, copy plan before attempting to rewrite
                 // as rewriting is destructive
                 let prev_plan = options