Skip to content

Commit 477d652

Browse files
committed
fix review issue. apache#3882
1 parent 84c3dde commit 477d652

File tree

4 files changed

+4
-34
lines changed

4 files changed

+4
-34
lines changed

dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public final class StringUtils {
5353
private static final Pattern INT_PATTERN = Pattern.compile("^\\d+$");
5454
private static final int PAD_LIMIT = 8192;
5555

56-
protected StringUtils() {
56+
private StringUtils() {
5757
}
5858

5959
/**

dubbo-compatible/src/main/java/com/alibaba/dubbo/common/utils/UrlUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import java.util.stream.Collectors;
2525

2626
/**
27-
* @author cvictory ON 2019-04-17
27+
* 2019-04-17
2828
*/
2929
@Deprecated
3030
public class UrlUtils {
@@ -34,7 +34,7 @@ public static URL parseURL(String address, Map<String, String> defaults) {
3434
}
3535

3636
public static List<URL> parseURLs(String address, Map<String, String> defaults) {
37-
return UrlUtils.parseURLs(address, defaults).stream().map(e -> new URL(e)).collect(Collectors.toList());
37+
return org.apache.dubbo.common.utils.UrlUtils.parseURLs(address, defaults).stream().map(e -> new URL(e)).collect(Collectors.toList());
3838
}
3939

4040
public static Map<String, Map<String, String>> convertRegister(Map<String, Map<String, String>> register) {

dubbo-compatible/src/main/java/com/alibaba/dubbo/registry/support/FailbackRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import java.util.stream.Collectors;
2525

2626
/**
27-
* @author cvictory ON 2019-04-17
27+
* 2019-04-17
2828
*/
2929
@Deprecated
3030
public abstract class FailbackRegistry implements org.apache.dubbo.registry.Registry, Registry {

dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/FailbackRegistry.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -206,52 +206,22 @@ private void removeFailedNotified(URL url, NotifyListener listener) {
206206
}
207207
}
208208

209-
/**
210-
* remove public modifier.
211-
*
212-
* @return
213-
* @since 2.7.2
214-
*/
215209
ConcurrentMap<URL, FailedRegisteredTask> getFailedRegistered() {
216210
return failedRegistered;
217211
}
218212

219-
/**
220-
* remove public modifier.
221-
*
222-
* @return
223-
* @since 2.7.2
224-
*/
225213
ConcurrentMap<URL, FailedUnregisteredTask> getFailedUnregistered() {
226214
return failedUnregistered;
227215
}
228216

229-
/**
230-
* remove public modifier.
231-
*
232-
* @return
233-
* @since 2.7.2
234-
*/
235217
ConcurrentMap<Holder, FailedSubscribedTask> getFailedSubscribed() {
236218
return failedSubscribed;
237219
}
238220

239-
/**
240-
* remove public modifier.
241-
*
242-
* @return
243-
* @since 2.7.2
244-
*/
245221
ConcurrentMap<Holder, FailedUnsubscribedTask> getFailedUnsubscribed() {
246222
return failedUnsubscribed;
247223
}
248224

249-
/**
250-
* remove public modifier.
251-
*
252-
* @return
253-
* @since 2.7.2
254-
*/
255225
ConcurrentMap<Holder, FailedNotifiedTask> getFailedNotified() {
256226
return failedNotified;
257227
}

0 commit comments

Comments
 (0)