Skip to content

Commit da0a104

Browse files
committed
Move @galaxyproject/galaxy-ui to devDependencies
galaxy-ui is "private": true and never gets published to npm. With it declared as a runtime dependency, pnpm publish would rewrite workspace:* to 0.0.0-internal in the published galaxy-client tarball, and consumers' npm install would then fail trying to fetch a non-existent package. galaxy-ui is a source dep only -- its compiled output is bundled into client/dist/ at build time, so consumers don't need it at install time.
1 parent 26a8397 commit da0a104

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
"@fortawesome/free-solid-svg-icons": "^5.15.4",
4444
"@fortawesome/vue-fontawesome": "^2.0.9",
4545
"@galaxyproject/galaxy-api-client": "workspace:*",
46-
"@galaxyproject/galaxy-ui": "workspace:*",
4746
"@guolao/vue-monaco-editor": "^1.5.4",
4847
"@handsontable/vue": "^2.0.0",
4948
"@hirez_io/observer-spy": "^2.1.2",
@@ -161,6 +160,7 @@
161160
"type-check": "vue-tsc --noEmit"
162161
},
163162
"devDependencies": {
163+
"@galaxyproject/galaxy-ui": "workspace:*",
164164
"@modyfi/vite-plugin-yaml": "^1.1.1",
165165
"@pinia/testing": "0.1.5",
166166
"@rollup/plugin-inject": "^5.0.5",

client/pnpm-lock.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)