Move ColorVariant into componentVariants.ts

ColorVariant lives with the other component variant types inside
BaseComponents/ so G-components don't need to reach back into
@/components/Common to get their own types. Common/index.ts re-exports
for the app-code consumers that still import it from there.

Prep work for carving BaseComponents into a @galaxyproject/galaxy-ui
workspace package -- the package needs its types self-contained.

Author: dannon

client/src/components/BaseComponents/GTip.vue

@@ -1,9 +1,10 @@
 <script setup lang="ts">
 import { computed, onUnmounted, ref } from "vue";
 
-import type { ColorVariant } from "@/components/Common";
 import { useMarkdown } from "@/composables/markdown";
 
+import type { ColorVariant } from "./componentVariants";
+
 interface Props {
     /** List of tip messages. Supports markdown formatting. Must contain at least one entry. */
     tips: string[];

client/src/components/BaseComponents/componentVariants.ts

@@ -1,6 +1,12 @@
 export type ComponentColor = "grey" | "blue" | "green" | "yellow" | "orange" | "red";
 export type ComponentSize = "small" | "medium" | "large";
 
+/**
+ * Basic color variants for components that only support
+ * color-based styling like alerts, badges, and backgrounds (no outline variants).
+ */
+export type ColorVariant = "primary" | "secondary" | "success" | "danger" | "warning" | "info" | "light" | "dark";
+
 export type ComponentSizeClassList = {
     [_key in `g-${ComponentSize}`]?: true;
 };

client/src/components/Common/index.ts

@@ -1,11 +1,9 @@
 import type { IconDefinition } from "@fortawesome/fontawesome-svg-core";
 import type { RawLocation } from "vue-router";
 
-/**
- * Basic color variants for components that only support
- * color-based styling like alerts, badges, and backgrounds (no outline variants).
- */
-export type ColorVariant = "primary" | "secondary" | "success" | "danger" | "warning" | "info" | "light" | "dark";
+import type { ColorVariant } from "@/components/BaseComponents/componentVariants";
+
+export type { ColorVariant } from "@/components/BaseComponents/componentVariants";
 
 /**
  * Bootstrap Vue variants for styling components.