Skip to content

Commit 8961589

Browse files
authored
Merge pull request #388 from dbarzin/dev
Dev
2 parents 3bd02aa + b32d322 commit 8961589

File tree

7 files changed

+42
-40
lines changed

7 files changed

+42
-40
lines changed

app/Http/Controllers/ControlController.php

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ public function index(Request $request)
291291
}
292292

293293
/**
294-
* Show the form for creating a new resource.
294+
* Show the form for creating a new Control.
295295
*
296296
* @return \Illuminate\Http\Response
297297
*/
@@ -323,9 +323,12 @@ public function create()
323323

324324
// get all attributes
325325
$values = [];
326-
$attributes = DB::table('measures')->select('attributes')->get();
326+
$attributes = DB::table('attributes')->select('values')
327+
->union(DB::table('measures')
328+
->select(DB::raw('attributes as value')))
329+
->get();
327330
foreach ($attributes as $key) {
328-
foreach (explode(' ', $key->attributes) as $value) {
331+
foreach (explode(' ', $key->values) as $value) {
329332
array_push($values, $value);
330333
}
331334
}
@@ -583,9 +586,12 @@ public function edit(int $id)
583586

584587
// get all attributes
585588
$values = [];
586-
$attributes = DB::table('measures')->select('attributes')->get();
589+
$attributes = DB::table('attributes')->select('values')
590+
->union(DB::table('measures')
591+
->select(DB::raw('attributes as value')))
592+
->get();
587593
foreach ($attributes as $key) {
588-
foreach (explode(' ', $key->attributes) as $value) {
594+
foreach (explode(' ', $key->values) as $value) {
589595
array_push($values, $value);
590596
}
591597
}
@@ -638,9 +644,12 @@ public function clone(Request $request)
638644

639645
// get all attributes
640646
$values = [];
641-
$attributes = DB::table('measures')->select('attributes')->get();
647+
$attributes = DB::table('attributes')->select('values')
648+
->union(DB::table('measures')
649+
->select(DB::raw('attributes as value')))
650+
->get();
642651
foreach ($attributes as $key) {
643-
foreach (explode(' ', $key->attributes) as $value) {
652+
foreach (explode(' ', $key->values) as $value) {
644653
array_push($values, $value);
645654
}
646655
}

app/Http/Controllers/MeasureController.php

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -95,18 +95,18 @@ public function create()
9595

9696
// get all attributes
9797
$values = [];
98-
$attributes = DB::table('attributes')
99-
->select('values')
100-
->get();
101-
foreach ($attributes as $attribute) {
102-
foreach (explode(' ', $attribute->values) as $value) {
103-
if (strlen($value) > 0) {
104-
array_push($values, $value);
105-
}
98+
$attributes = DB::table('attributes')->select('values')
99+
->union(DB::table('measures')
100+
->select(DB::raw('attributes as value')))
101+
->get();
102+
foreach ($attributes as $key) {
103+
foreach (explode(' ', $key->values) as $value) {
104+
array_push($values, $value);
106105
}
107-
sort($values);
108-
$values = array_unique($values);
109106
}
107+
sort($values);
108+
$values = array_unique($values);
109+
110110
// for clone action
111111
$measure = null;
112112

@@ -235,14 +235,13 @@ public function edit(int $id)
235235

236236
// get all attributes
237237
$values = [];
238-
$attributes = DB::table('attributes')
239-
->select('values')
240-
->get();
241-
foreach ($attributes as $attribute) {
242-
foreach (explode(' ', $attribute->values) as $value) {
243-
if (strlen($value) > 0) {
244-
array_push($values, $value);
245-
}
238+
$attributes = DB::table('attributes')->select('values')
239+
->union(DB::table('measures')
240+
->select(DB::raw('attributes as value')))
241+
->get();
242+
foreach ($attributes as $key) {
243+
foreach (explode(' ', $key->values) as $value) {
244+
array_push($values, $value);
246245
}
247246
}
248247
sort($values);
@@ -533,7 +532,7 @@ public function activate(Request $request)
533532
$control = new Control();
534533
$control->name = $request->get('name');
535534
$control->scope = $request->get('scope');
536-
$control->attributes = $request->get('attributes[]');
535+
$control->attributes = request('attributes') !== null ? implode(' ', request('attributes')) : null;
537536
$control->objective = $request->get('objective');
538537
$control->input = $request->get('input');
539538
$control->model = $request->get('model');

app/Providers/AppServiceProvider.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@
44

55
use DB;
66
use Illuminate\Support\Facades\App;
7+
use Illuminate\Support\Facades\Blade;
78
use Illuminate\Support\Facades\Config;
89
use Illuminate\Support\Facades\Event;
910
use Illuminate\Support\Facades\URL;
11+
use Illuminate\Support\Number;
1012
use Illuminate\Support\ServiceProvider;
1113
use Log;
1214

@@ -52,6 +54,7 @@ public function boot()
5254
$this->bootOIDCSocialite();
5355
}
5456

57+
// Show appVersion from version.txt in Blades
5558
view()->composer('*', function ($view) {
5659
$version = trim(file_get_contents(base_path('version.txt')));
5760
$view->with('appVersion', $version);

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "2025.05.18",
2+
"version": "2025.05.20",
33
"license": "GPL-3.0",
44
"author": "Didier Barzin",
55
"repository": "https://www.github.com/dbarzin/deming",

resources/views/documents/check.blade.php

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
@extends("layout")
22

33
@section("content")
4-
5-
<?php
6-
function bytesToHuman($bytes) {
7-
$units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB'];
8-
for ($i = 0; $bytes > 1024; $i++) $bytes /= 1024;
9-
return round($bytes, 2) . ' ' . $units[$i];
10-
}
11-
?>
12-
134
<div data-role="panel" data-title-caption="{{ trans('cruds.document.list') }}" data-collapsible="false" data-title-icon="<span class='mif-file-text'></span>">
145

156
<table class="table">
@@ -35,7 +26,7 @@ function bytesToHuman($bytes) {
3526
<a href="/doc/show/{{ $doc->id }}">{{ substr($doc->filename,0,32) }}</a>
3627
</td>
3728
<td>
38-
{{ bytesToHuman($doc->size) }}
29+
{{ \Illuminate\Support\Number::fileSize($doc->size) }}
3930
</td>
4031
<td>
4132
{{ $doc->hash }}

version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2025.05.18
1+
2025.05.20

0 commit comments

Comments
 (0)