Skip to content

Commit 9393d3d

Browse files
committed
add missing fields
1 parent fdaae24 commit 9393d3d

File tree

3 files changed

+26
-20
lines changed

3 files changed

+26
-20
lines changed

app/Http/Controllers/API/MeasureController.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class MeasureController extends Controller
1212
{
1313
public function index()
1414
{
15-
abort_if(Auth::User()->role !== 4, Response::HTTP_FORBIDDEN, '403 Forbidden');
15+
abort_if(Auth::User()->isAPI(), Response::HTTP_FORBIDDEN, '403 Forbidden');
1616

1717
$measures = Measure::all();
1818

@@ -21,9 +21,9 @@ public function index()
2121

2222
public function store(Request $request)
2323
{
24-
abort_if(Auth::User()->role !== 4, Response::HTTP_FORBIDDEN, '403 Forbidden');
24+
abort_if(Auth::User()->isAPI(), Response::HTTP_FORBIDDEN, '403 Forbidden');
2525

26-
$measure = Measure::create($request->all());
26+
$measure = Measure::query()->create($request->all());
2727
if ($request->has('controls')) {
2828
$measure->controls()->sync($request->input('controls', []));
2929
}
@@ -33,14 +33,14 @@ public function store(Request $request)
3333

3434
public function show(Measure $measure)
3535
{
36-
abort_if(Auth::User()->role !== 4, Response::HTTP_FORBIDDEN, '403 Forbidden');
36+
abort_if(Auth::User()->isAPI(), Response::HTTP_FORBIDDEN, '403 Forbidden');
3737

3838
return response()->json($measure);
3939
}
4040

4141
public function update(Request $request, Measure $measure)
4242
{
43-
abort_if(Auth::User()->role !== 4, Response::HTTP_FORBIDDEN, '403 Forbidden');
43+
abort_if(Auth::User()->isAPI(), Response::HTTP_FORBIDDEN, '403 Forbidden');
4444

4545
$measure->update($request->all());
4646
if ($request->has('controls')) {
@@ -52,7 +52,7 @@ public function update(Request $request, Measure $measure)
5252

5353
public function destroy(Measure $measure)
5454
{
55-
abort_if(Auth::User()->role !== 4, Response::HTTP_FORBIDDEN, '403 Forbidden');
55+
abort_if(Auth::User()->isAPI(), Response::HTTP_FORBIDDEN, '403 Forbidden');
5656

5757
$measure->delete();
5858

app/Http/Controllers/MeasureController.php

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use Illuminate\Support\Facades\DB;
1414
use Illuminate\View\View;
1515
use Maatwebsite\Excel\Facades\Excel;
16+
use Mercator\Core\Models\Task;
1617

1718
class MeasureController extends Controller
1819
{
@@ -195,18 +196,20 @@ public function store(Request $request)
195196
]
196197
);
197198

198-
$measure = new Measure();
199-
$measure->domain_id = request('domain_id');
200-
$measure->clause = request('clause');
201-
$measure->name = request('name');
202-
$measure->attributes = request('attributes') !== null ? implode(' ', request('attributes')) : null;
203-
$measure->objective = request('objective');
204-
$measure->input = request('input');
205-
$measure->model = request('model');
206-
$measure->indicator = request('indicator');
207-
$measure->action_plan = request('action_plan');
208-
209-
$measure->save();
199+
$request['attributes'] = implode(' ', $request->get('attributes') !== null ? $request->get('attributes') : []);
200+
201+
$measure = Measure::query()->create($request->all());
202+
// $measure = new Measure();
203+
// $measure->domain_id = request('domain_id');
204+
// $measure->clause = request('clause');
205+
// $measure->name = request('name');
206+
// $measure->attributes = request('attributes') !== null ? implode(' ', request('attributes')) : null;
207+
// $measure->objective = request('objective');
208+
// $measure->input = request('input');
209+
// $measure->model = request('model');
210+
// $measure->indicator = request('indicator');
211+
// $measure->action_plan = request('action_plan');
212+
// $measure->save();
210213

211214
$request->session()->put('domain', $measure->domain_id);
212215

app/Models/Measure.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,15 @@ class Measure extends Model
2828
];
2929

3030
protected $fillable = [
31-
'name',
31+
'domain_id',
3232
'clause',
33+
'name',
3334
'objective',
34-
'input',
3535
'attributes',
36+
'input',
3637
'model',
38+
'indicator',
39+
'action_plan',
3740
];
3841

3942
// Return the domain associated to this measure

0 commit comments

Comments
 (0)