Merge trunk: adopt wp-env CI approach, remove stubs

Merge latest trunk which uses wp-env for WordPress-dependent CI tests.
Add Plugin Directory to the wp-env CI matrix. Remove Classic_Search
and WPORG_Ratings stubs as they are not needed (Jetpack is installed
via wp-env, and WPORG_Ratings is guarded by class_exists checks).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: dd32

.github/workflows/unit-tests.yml

@@ -1,9 +1,8 @@
 name: Unit Tests
 
 on:
-  push:
-    branches: [ trunk ]
   pull_request:
+  push:
     branches: [ trunk ]
 
 jobs:
@@ -52,52 +51,39 @@ jobs:
         working-directory: ${{ matrix.working-directory }}
         run: phpunit ${{ matrix.phpunit-args }}
 
-  # WordPress-dependent PHP tests — require the WP test framework and MySQL.
+  # WordPress-dependent PHP tests — require wp-env (Docker).
   php-wordpress:
-    name: "WP PHP: ${{ matrix.name }}"
+    name: "WP: ${{ matrix.name }}"
     runs-on: ubuntu-latest
-    services:
-      mysql:
-        image: mysql:8.0
-        env:
-          MYSQL_ROOT_PASSWORD: root
-          MYSQL_DATABASE: wordpress_test
-        ports:
-          - 3306:3306
-        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
     strategy:
       fail-fast: false
       matrix:
         include:
           - name: Handbook Plugin
-            working-directory: wordpress.org/public_html/wp-content/plugins/handbook
-            phpunit-args: "--configuration phpunit.xml.dist"
+            plugin-directory: wordpress.org/public_html/wp-content/plugins/handbook
+            phpunit-args: "--no-configuration --bootstrap phpunit/bootstrap.php phpunit/tests/"
           - name: Plugin Directory
-            working-directory: wordpress.org/public_html/wp-content/plugins/plugin-directory
+            plugin-directory: wordpress.org/public_html/wp-content/plugins/plugin-directory
             phpunit-args: "--configuration phpunit.xml --group plugin-directory"
     steps:
       - uses: actions/checkout@v4
 
-      - name: Set up PHP
-        uses: shivammathur/setup-php@v2
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
         with:
-          php-version: "8.4"
-          extensions: mysqli
-          tools: phpunit:9.6
+          node-version: 20
 
-      - name: Install WordPress test suite
-        run: |
-          git clone --depth=1 https://github.com/WordPress/wordpress-develop.git /tmp/wp-develop
-          cd /tmp/wp-develop && composer install --no-interaction
-          cp wp-tests-config-sample.php tests/phpunit/wp-tests-config.php
-          sed -i "s|dirname( __FILE__ ) . '/src/'|'/tmp/wp-develop/src/'|" tests/phpunit/wp-tests-config.php
-          sed -i "s/youremptytestdbnamehere/wordpress_test/" tests/phpunit/wp-tests-config.php
-          sed -i "s/yourusernamehere/root/" tests/phpunit/wp-tests-config.php
-          sed -i "s/yourpasswordhere/root/" tests/phpunit/wp-tests-config.php
-          sed -i "s/'localhost'/'127.0.0.1'/" tests/phpunit/wp-tests-config.php
+      - name: Install wp-env
+        run: npm -g install @wordpress/env
+
+      - name: Start wp-env
+        working-directory: ${{ matrix.plugin-directory }}
+        run: wp-env start
+
+      - name: Install PHPUnit Polyfills
+        working-directory: ${{ matrix.plugin-directory }}
+        run: wp-env run tests-cli composer require --dev yoast/phpunit-polyfills:^4.0 --working-dir=/wordpress-phpunit
 
       - name: Run PHPUnit
-        working-directory: ${{ matrix.working-directory }}
-        env:
-          WP_TESTS_DIR: /tmp/wp-develop/tests/phpunit
-        run: phpunit ${{ matrix.phpunit-args }}
+        working-directory: ${{ matrix.plugin-directory }}
+        run: wp-env run tests-cli --env-cwd=wp-content/plugins/$(basename ${{ matrix.plugin-directory }}) phpunit ${{ matrix.phpunit-args }}

wordpress.org/public_html/wp-content/plugins/handbook/phpunit/bootstrap.php

@@ -14,6 +14,10 @@
 if ( ! $_tests_dir && false !== ( $pos = stripos( __FILE__, '/src/wp-content/plugins/' ) ) ) {
 	$_tests_dir = substr( __FILE__, 0, $pos ) . '/tests/phpunit/';
 }
+// Check for wp-env test directory.
+elseif ( ! $_tests_dir && file_exists( '/wordpress-phpunit/includes/functions.php' ) ) {
+	$_tests_dir = '/wordpress-phpunit/';
+}
 // Elseif no path yet, assume a temp directory path.
 elseif ( ! $_tests_dir ) {
 	$_tests_dir = rtrim( sys_get_temp_dir(), '/\\' ) . '/wordpress-tests-lib/tests/phpunit/';
@@ -24,6 +28,11 @@
 	exit( 1 );
 }
 
+// Set polyfills path if available (required by WP test suite).
+if ( ! defined( 'WP_TESTS_PHPUNIT_POLYFILLS_PATH' ) && file_exists( $_tests_dir . '/vendor/yoast/phpunit-polyfills' ) ) {
+	define( 'WP_TESTS_PHPUNIT_POLYFILLS_PATH', $_tests_dir . '/vendor/yoast/phpunit-polyfills' );
+}
+
 // Give access to tests_add_filter() function.
 require_once $_tests_dir . '/includes/functions.php';
 

wordpress.org/public_html/wp-content/plugins/handbook/phpunit/tests/handbook.php

@@ -17,15 +17,15 @@ class WPorg_Handbook_Handbook_Test extends WP_UnitTestCase {
 
 	protected $handbook;
 
-	public function setUp() {
+	public function setUp(): void {
 		parent::setup();
 		WPorg_Handbook_Init::init();
 
 		$handbooks = WPorg_Handbook_Init::get_handbook_objects();
 		$this->handbook = reset( $handbooks );
 	}
 
-	public function tearDown() {
+	public function tearDown(): void {
 		parent::tearDown();
 
 		foreach ( WPorg_Handbook_Init::get_handbook_objects() as $obj ) {
@@ -455,7 +455,7 @@ public function test_handbook_sidebar() {
 
 		$this->assertTrue( isset( $wp_registered_sidebars[ 'handbook' ] ) );
 		$this->assertSame(
-			[ 'name', 'id', 'description', 'class', 'before_widget', 'after_widget', 'before_title', 'after_title', 'before_sidebar', 'after_sidebar' ],
+			[ 'name', 'id', 'description', 'class', 'before_widget', 'after_widget', 'before_title', 'after_title', 'before_sidebar', 'after_sidebar', 'show_in_rest' ],
 			array_keys( $wp_registered_sidebars[ 'handbook' ] )
 		);
 		$this->assertEquals( 'handbook', $wp_registered_sidebars[ 'handbook' ]['id'] );

wordpress.org/public_html/wp-content/plugins/handbook/phpunit/tests/init.php

@@ -4,13 +4,13 @@
 
 class WPorg_Handbook_Init_Test extends WP_UnitTestCase {
 
-	public function setUp() {
+	public function setUp(): void {
 		parent::setup();
 
 		WPorg_Handbook_Init::init();
 	}
 
-	public function tearDown() {
+	public function tearDown(): void {
 		parent::tearDown();
 
 		WPorg_Handbook_Init::reset( true );

wordpress.org/public_html/wp-content/plugins/handbook/phpunit/tests/template-tags.php

@@ -4,13 +4,13 @@
 
 class WPorg_Handbook_Template_Tags_Test extends WP_UnitTestCase {
 
-	public function setUp() {
+	public function setUp(): void {
 		parent::setup();
 
 		WPorg_Handbook_Init::init();
 	}
 
-	public function tearDown() {
+	public function tearDown(): void {
 		parent::tearDown();
 
 		WPorg_Handbook_Init::reset( true );

wordpress.org/public_html/wp-content/plugins/plugin-directory/.wp-env.json

@@ -10,7 +10,5 @@
 		"../../../themes/pub/wporg-plugins-2024",
 		"https://github.com/WordPress/wporg-parent-2021"
 	],
-	"mappings": {
-		"wp-content/mu-plugins/wporg-ratings-stub.php": "./tests/stubs/wporg-ratings-stub.php"
-	}
+	"mappings": {}
 }

wordpress.org/public_html/wp-content/plugins/plugin-directory/tests/bootstrap.php

@@ -26,9 +26,6 @@
 // Give access to tests_add_filter() function.
 require_once $_tests_dir . '/includes/functions.php';
 
-// Load Jetpack Search stub if Jetpack is not installed.
-require_once __DIR__ . '/stubs/jetpack-search-stub.php';
-
 /**
  * Manually load the plugin being tested.
  */