Skip to content

Commit 17d69df

Browse files
Merge pull request #2 from debsmita1/fix/global-fab
updated the FAB menu actions
2 parents 5f6bb2f + ea6ec5f commit 17d69df

File tree

2 files changed

+8
-17
lines changed
  • workspaces/global-floating-action-button
    • packages/app/src/components/Root
    • plugins/global-floating-action-button/src/components

2 files changed

+8
-17
lines changed

workspaces/global-floating-action-button/packages/app/src/components/Root/Root.tsx

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,14 @@ export const Root = ({ children }: PropsWithChildren<{}>) => {
9898
},
9999
{
100100
slot: Slot.BOTTOM_LEFT,
101-
icon: <LibraryBooks />,
102-
label: 'Api Docs',
103-
toolTip: 'Api Docs',
101+
icon: <ExtensionIcon />,
102+
label: 'Apis',
103+
toolTip: 'Apis',
104104
to: '/api-docs',
105105
},
106106
{
107107
slot: Slot.BOTTOM_LEFT,
108-
icon: <ExtensionIcon />,
108+
icon: <LibraryBooks />,
109109
showLabel: true,
110110
label: 'Docs',
111111
toolTip: 'Docs',
@@ -118,22 +118,13 @@ export const Root = ({ children }: PropsWithChildren<{}>) => {
118118
onClick: toggleModal,
119119
},
120120
{
121-
color: 'success',
122121
icon: <GitHubIcon />,
123-
label: 'RHDH pluginsssssssssssssss',
122+
label: 'RHDH plugins',
124123
showLabel: true,
125124
toolTip: 'RHDH plugins',
126125
to: 'https://github.com/redhat-developer/rhdh-plugins',
127126
visibleOnPaths: ['/catalog'],
128127
},
129-
{
130-
color: 'success',
131-
icon: <GitHubIcon />,
132-
label: 'RHDH pluginsssssssssssssss',
133-
toolTip: 'External link',
134-
to: 'https://github.com/redhat-developer/rhdh-plugins',
135-
visibleOnPaths: ['/catalog'],
136-
},
137128
{
138129
color: 'success',
139130
icon: <UserSettingsSignInAvatar />,

workspaces/global-floating-action-button/plugins/global-floating-action-button/src/components/FAB.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const FABLabel = ({
4545
const styles = useStyles();
4646
const marginStyle = slotOptions[slot].margin;
4747
return (
48-
<Typography sx={{ display: 'flex' }}>
48+
<>
4949
{showExternalIcon && (
5050
<OpenInNewIcon
5151
className={styles.openInNew}
@@ -68,11 +68,11 @@ const FABLabel = ({
6868
</Typography>
6969
)}
7070
{icon && (
71-
<Typography sx={{ mb: -1, order: order.icon }}>
71+
<Typography sx={{ order: order.icon }}>
7272
<FabIcon icon={icon} />
7373
</Typography>
7474
)}
75-
</Typography>
75+
</>
7676
);
7777
};
7878

0 commit comments

Comments
 (0)